Changeset 12890

Timestamp:

04/17/2021 08:31:38 AM (4 years ago)

Author:

imath

Message:

BP Nouveau: improve the way we get the nonce in JavaScript main file

Splitting the data-bp-nonce attribute to get Ajax buttons nonce is not the right way to do it. There can be situation where the _wpnonce URL param is not the last one (eg: the data-bp-nonce attribute of the Accept Group Invite button contains a redirect_to param). Using the bp.Nouveau.getLinkParams() function is fixing the issue.

Prop meijioro

Fixes #8396

File:

• trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js

@@ -662 +662 @@
             }
 
-            // Find the required wpnonce string.
-            // if  button element set we'll have our nonce set on a data attr
-            // Check the value & if exists split the string to obtain the nonce string
-            // if no value, i.e false, null then the href attr is used.
-            if ( nonceUrl ) {
-                nonce = nonceUrl.split('?_wpnonce=');
-                nonce = nonce[1];
-            } else {
-                nonce = self.getLinkParams( target.prop( 'href' ), '_wpnonce' );
-            }
+            // If the nonceUrl is not set, use the `href` attribute.
+            if ( ! nonceUrl ) {
+                nonceUrl = target.prop( 'href' );
+            }
+
+            // Set the nonce.
+            nonce = self.getLinkParams( nonceUrl, '_wpnonce' );
 
             // Unfortunately unlike groups