We should have `Secondary Item Id` in filters for `friends_format_notifications` function

[bhargavbhandari90]

In file src/bp-friends/bp-friends-notifications.php

We have a function friends_format_notifications to get notification of user friendships.

In the function there are 4 filters as follow:

• - bp_friends_single_friendship_accepted_notification
• - bp_friends_multiple_friendship_accepted_notification
• - bp_friends_single_friendship_request_notification
• - bp_friends_multiple_friendship_request_notification

But for these filters, we don't have secondary item id passed in arguments. Some users might need that secondary item id as well.

Let me know if there is specific reason not to pass secondary item id in those filters.

[bhargavbhandari90]

made documentation alignment proper

[imath]

Thanks for your patch @bhargavbhandari90, let's work on it during the next development cycle.

[bhargavbhandari90]

Replying to imath:

Thanks for your patch @bhargavbhandari90, let's work on it during the next development cycle.

Sure.

[dcavins]

Looks good to me. Let's add the parameter to both the string and array versions of the logic. Thanks, @bhargavbhandari90!

[bhargavbhandari90]

Add secondary id in filter to array format

[bhargavbhandari90]

Replying to dcavins:

Looks good to me. Let's add the parameter to both the string and array versions of the logic. Thanks, @bhargavbhandari90!

Thanks @dcavins . I forgot about that.

[imath]

Move the first tickets to next major release.

[espellcaste]

@imath This one seems to have an "approved" patch from @dcavins

Do you have any feedback, with improvements to the patch or possible breaking changes it might incur?

[imath]

I believe ​.2.patch can be committed what do you think @dcavins

[imath]

In 12597:

BP Friends: improve the filter of the formatting notification function

Add the $secondary_item_id parameter to the following dynamic filter:
bp_friends_{$amount}_friendship_{$action}_notification

Props bhargavbhandari90, dcavins, espellcaste

Fixes #8136