Skip to:
Content

BuddyPress.org

Opened 8 months ago

Closed 8 months ago

#8135 closed defect (bug) (fixed)

Many failing test under WordPress 5.3

Reported by: imath Owned by: netweb
Milestone: 5.0.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Cc:

Description

  • Most of them involve the line 200 of bp-friends/classes/class-bp-friends-friendship.php : I've found out using do_action_ref_array() instead of do_action() is fixing the failing tests.
  • One involves line 45 of tests/phpunit/testcases/members/template.php : WordPress now uses " instead of ' in href attributes of the output of the paginate_links() function.

Attachments (1)

8135.patch (3.0 KB) - added by imath 8 months ago.

Download all attachments as: .zip

Change History (2)

@imath
8 months ago

#1 @imath
8 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12459:

Fix failing tests under WordPress trunk (5.3)

  1. Use do_action_ref_array() instead of do_action() to pass the BP_Friends_Friendship object by reference.
  2. Adapts the test_bp_has_members_search_pagination_with_spaces() test to WordPress changes in the paginate_links() function.

Fixes #8135

Note: See TracTickets for help on using tickets.