Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

#8137 closed enhancement (fixed)

Allow overriding field autolinking from field type

Reported by: sbrajesh's profile sbrajesh Owned by: imath's profile imath
Milestone: 6.0.0 Priority: normal
Severity: normal Version: 2.5.0
Component: Extended Profile Keywords: good-first-bug has-patch commit
Cc: sbrajesh

Description

Hi,
Currently, The auto linking is not controllable from field type(unless you hack around it and meta).

Not all fields are auto linkable(example, oembed, role etc ).

There should be a simple way to allow developers either toggle support for auto linking in admin(type supports check?) or atleast disable the filtering on the front end.
We can add a new method or field on the field type class to check if we should auto link or not.

It is feasible to disable but there is no direct way. Can we make it simple?

Thank you
Brajesh

Attachments (1)

8137.diff (699 bytes) - added by sbrajesh 4 years ago.
Filter do_autolink for xprofile field.

Download all attachments as: .zip

Change History (9)

#1 @sbrajesh
5 years ago

Or may be even adding a filter in the

get_do_autolink()

which passes the field id or object will suffice.

Thank you
Brajesh

#2 @boonebgorges
5 years ago

  • Component changed from Core to Extended Profile
  • Keywords needs-patch good-first-bug added

Yes, we can probably do both of these - a property on Field_Type objects as registered in plugins, and a filter. Can you suggest a patch?

#3 @sbrajesh
5 years ago

Thank you for the prompt reply. Sure, I will love to.

Since these two approaches are not mutually exclusive, I guess, we will need 2 different patches ?
Should I add the filter first and then the other one?

Thank you

Last edited 5 years ago by sbrajesh (previous) (diff)

#4 @boonebgorges
5 years ago

One or two patches, either way. Thank you!

#5 @sbrajesh
4 years ago

  • Keywords has-patch added; needs-patch removed

Thank you. My apologies for the delay.
Please find the patch with the filter for do autolink.

@sbrajesh
4 years ago

Filter do_autolink for xprofile field.

#6 @sbrajesh
4 years ago

  • Version set to 5.0.0

Adding version to get another review on the ticket.

#7 @imath
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.0.0
  • Version changed from 5.0.0 to 2.5.0

Thanks for your contribution @sbrajesh. It looks good, let's have it in for 6.0.0.

#8 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12532:

xProfile: introduce a new filter to edit the field's autolink property

props sbrajesh

Fixes #8137

Note: See TracTickets for help on using tickets.