Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7963 closed defect (bug) (fixed)

Activity item: Secondary avatar and user name/group name create duplicated link.

Reported by: dcavins's profile dcavins Owned by: djpaul's profile djpaul
Milestone: 4.0 Priority: low
Severity: minor Version: 3.0.0
Component: Templates Keywords: has-patch needs-screenshots commit
Cc: dcavins

Description

bp_nouveau_activity_secondary_avatars() duplicates logic from bp-legacy in which the secondary activity item's avatar is inserted in the activity header before the text link to that secondary item. WCAG prefers that these items be contained within a single link: ​https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H2

Attachments (2)

activity-item-before.png​ (16.7 KB) - added by dcavins 6 years ago.
Screenshot showing duplicated link.
7963.01.diff​ (1.1 KB) - added by dcavins 6 years ago.
Patch updating avatar-injecting logic in Nouveau.

Download all attachments as: .zip

Change History (6)

@dcavins
6 years ago

Screenshot showing duplicated link.

@dcavins
6 years ago

Patch updating avatar-injecting logic in Nouveau.

#1 @DJPaul
6 years ago

  • Keywords needs-screenshots added; has-screenshots removed
  • Milestone changed from Awaiting Review to 4.0

Looks good. I will also buy you a doughnut if you adjust that comparison with the assignment into separate lines, while you're there.

#2 @DJPaul
6 years ago

  • Keywords commit added

#3 @djpaul
6 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from assigned to closed

In 12269:

Activity: consolidate secondary activity avatar and name into one link.

Per WCAG guidelines, these should be a single link.
See ​https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H2

Fixes #7963

Thanks to dcavins

#4 @boonebgorges
6 years ago

In 12283:

Fix varibale name typo introduced in [12269].

See #7963.

Note: See TracTickets for help on using tickets.