Changeset 12269

Timestamp:

11/02/2018 12:39:53 PM (8 years ago)

Author:

djpaul

Message:

Activity: consolidate secondary activity avatar and name into one link.

Per WCAG guidelines, these should be a single link.
See ​https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H2

Fixes #7963

Thanks to dcavins

File:

• trunk/src/bp-templates/bp-nouveau/includes/activity/functions.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/activity/functions.php

@@ -359 +359 @@
                 case 'groups':
                 case 'friends':
+                        $secondary_avatar = bp_get_activity_secondary_avatar( array( 'linked' => false ) );
+
                         // Only insert avatar if one exists.
-                        if ( $secondary_avatar = bp_get_activity_secondary_avatar() ) {
-                                $reverse_content = strrev( $action );
-                                $position        = strpos( $reverse_content, 'a<' );
-                                $action          = substr_replace( $action, $secondary_avatar, -$position - 2, 0 );
+                        if ( $secondary_avatar ) {
+                                $link_close  = '">';
+                                $first_link  = strpos( $action, $link_close );
+                                $second_link = strpos( $action, $link_close, $first_link + strlen( link_close ) );
+                                $action      = substr_replace( $action, $secondary_avatar, $second_link + 2, 0 );
                         }
                         break;