Skip to:

Opened 6 years ago

Closed 6 years ago

#7940 closed defect (bug) (fixed)

Nouveau - Don't add CSS declarations universally to parent elements

Reported by: shubh14's profile shubh14 Owned by: boonebgorges's profile boonebgorges
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords:
Cc: hnla



I am noticing a lot of issues with bp-nouveau template. I have also tested these issues on a fresh install, so there arent any theme/plugin conflicts.

In these two images I can see the tag and <a> tag on the page - <a href="" rel="noopener" target="_blank"></a> /

This part of the CSS is getting applied all over the site and I do not want my non-buddypress elements to have these properties. Is it not better to use .buddypress div{} instead of just div{} - <a href="" rel="noopener" target="_blank"></a>

Buddypress Version 3.1.0
Wordpress Version 4.9.7

I have never submitted a ticket before so please forgive any errors

Attachments (3)

Untitled-1.jpg (122.9 KB) - added by shubh14 6 years ago.
Untitled-2.jpg (149.6 KB) - added by shubh14 6 years ago.
Untitled-3.jpg (53.8 KB) - added by shubh14 6 years ago.

Download all attachments as: .zip

Change History (10)

6 years ago

6 years ago

6 years ago

#1 @r-a-y
6 years ago

  • Keywords reporter-feedback added

The first two issues are already reported - #7894, #7923.

With regards to your third issue, what are you trying to say? That there shouldn't be a border-radius in the forum thread? Or is there something wrong with the background? I should have done a better job reading! I understand now. Don't add CSS declarations universally to the div (and other) elements.

Last edited 6 years ago by r-a-y (previous) (diff)

#2 @r-a-y
6 years ago

  • Cc hnla added
  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.2.0
  • Summary changed from Html and CSS Issues with bp-nouveau to Nouveau - Don't add CSS declarations universally to parent elements

#3 @dunhakdis
6 years ago

I think it would be better if those "universal tags" could be wrapped inside #buddypress-main or #buddypress

#4 @DJPaul
6 years ago

  • Milestone changed from 3.2.0 to 4.0

Not sure why it was written this way but we will change the CSS for 4.0.0 as I think we need a little formal testing rather than throwing it into a 3.2.0 with not much oversight.

#5 @r-a-y
6 years ago

#8000 was marked as a duplicate.

#6 @boonebgorges
6 years ago

It looks like this was originally introduced in There's no indication there or elsewhere why it was done like this, but I'm assuming it was an oversight. I've done some testing with the declarations applied only to #buddypress and things look good. Let's go ahead with the change.

#7 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 12285:

Nouveau: border-radius declaration should be limited to #buddypress context.

The initial implementation was unbounded, affecting parts of a theme outside
of BuddyPress.

The change also includes some unrelated autoprefix changes due to running the
grunt sass task.

See #8000. Fixes #7940.

Note: See TracTickets for help on using tickets.