Nouveau - Paragraph elements are escaped for group descriptions

[MorgunovVit]

Hi!
I think, that it’s a mistake in file: plugins\buddypress\bp-groups\bp-groups-template.php
Instead

<?php echo esc_html( bp_nouveau_group_meta()->description ); ?>

need to be:

<?php echo wp_specialchars_decode( bp_nouveau_group_meta()->description ); ?>

Because in another way it prints on site page something like this: Screenshot ​https://prnt.sc/k58j6l

[dcavins]

Remove esc_html() wrapper.

[dcavins]

Closed duplicate: #7930

[imath]

Closed duplicate #7961

So this seems to be something very annoying for people using the BP Nouveau template pack. Thanks a lot @dcavins for this first patch, but seeing an unescaped string is giving me headaches ! :)

I'm going to work on this and will submit a new patch asap.

[imath]

After looking deeper into this issue. Here is some contextual information :

• One of the concerns of @hnla (correct me if I'm wrong :) ) was to make sure no empty markup was generated by BP Nouveau.
• The Group description has a specific customizer setting where the Admin can choose to display this description within the default Groups front page's body instead of the Group's header.

The ​7923.2.patch is taking these two points in account, and directly use the existing core template tag bp_group_description() instead of the bp_nouveau_group_meta()->description property that is causing some confusion imho. FYI hnla I also added some style rules to the paragraph because it was weird to have a big empty space before the bottom of the header's group description box.

If @MorgunovVit &/or @dcavins &/or @marcella1981 who reported the bug could test the patch and confirm it's fixing the issue : that would be really great !

[marcella1981]

*manual merge test only from me. Output as expected.

GJ @imath.

[dcavins]

Hi @imath-

Thanks for updating the patch. Your proposed fix, replacing esc_html( bp_nouveau_group_meta()->description ) with bp_group_description(), works for me. :)

[imath]

@marcella1981 & @dcavins Thanks a lot for tour feedbacks, I’ll commit the patch later tonight.

[imath]

In 12214:

BP Nouveau: Avoid escaping single Group description after sanitization

Props MorgunovVit dcavins marcella1981

See #7923 (branch 3.0)

[imath]

In 12215:

BP Nouveau: Avoid escaping single Group description after sanitization

Props MorgunovVit dcavins marcella1981

Fixes #7923 (trunk)