Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#7934 closed defect (bug) (fixed)

Nouveau - JS breaks customizer functionality

Reported by: r-a-y's profile r-a-y Owned by: imath's profile imath
Milestone: 3.2.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch commit
Cc:

Description

Received a few reports of this issue on the forums:
​https://buddypress.org/support/topic/cannot-read-property-selector-of-undefined/

WordPress customizer appears to break with Nouveau's customizer.js.

customizer.min.js:1 Uncaught TypeError: Cannot read property 'selector' of undefined
    at HTMLDocument.<anonymous> (customizer.min.js:1)
    at i (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,underscore,wp-a11y,wp-util,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,jquery-&load[]=ui-draggable,jquery-ui-droppable,backbone,wp-backbone,jquery-ui-resizable&ver=4.9.7:2)
    at Object.fireWith [as resolveWith] (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,underscore,wp-a11y,wp-util,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,jquery-&load[]=ui-draggable,jquery-ui-droppable,backbone,wp-backbone,jquery-ui-resizable&ver=4.9.7:2)
    at Function.ready (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,underscore,wp-a11y,wp-util,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,jquery-&load[]=ui-draggable,jquery-ui-droppable,backbone,wp-backbone,jquery-ui-resizable&ver=4.9.7:2)
    at HTMLDocument.K (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,underscore,wp-a11y,wp-util,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,jquery-&load[]=ui-draggable,jquery-ui-droppable,backbone,wp-backbone,jquery-ui-resizable&ver=4.9.7:2)

https://i.imgur.com/ABT38PB.png

Apparently occurs for all themes, but I haven't been able to duplicate.

Added as a ticket to get more eyes.

Attachments (1)

7934.patch​ (3.1 KB) - added by imath 7 years ago.

Download all attachments as: .zip

Change History (7)

#1 @imath
7 years ago

Thanks for the report @r-a-y I’ll try to look at this asap,

@imath
7 years ago

#2 @imath
7 years ago

  • Keywords has-patch reporter-feedback added

I've been able to replicate. This happens when the Group component is not active. ​7914.patch should fix the issue. Ideally if one of the reporters could test the patch & confirm it's fixing the issue it would be great.

#3 @cyberwani
7 years ago

I applied the patch and tested with all default themes (twenty-*) and two custom themes and it works fine.

#4 @r-a-y
7 years ago

  • Keywords commit added; needs-testing reporter-feedback removed

Thanks for testing, @cyberwani.

Good catch, @imath! Feel free to commit.

#5 @imath
7 years ago

In 12196:

BP Nouveau: make sure the Group Front Page customizer control exists

When the Groups component is not active, the Group Front page customizer control is not available. To avoid a JavaScript error and play nicer with the customizer we need to check this control is available before manipulating it.

Props r-a-y, cyberwani

See #7934 (Branch 3.0)

#6 @imath
7 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12197:

BP Nouveau: make sure the Group Front Page customizer control exists

When the Groups component is not active, the Group Front page customizer control is not available. To avoid a JavaScript error and play nicer with the customizer we need to check this control is available before manipulating it.

Props r-a-y, cyberwani

Fixes #7934 (Trunk)

Note: See TracTickets for help on using tickets.