Changeset 12197

Timestamp:

07/26/2018 03:47:11 AM (6 years ago)

Author:

imath

Message:

BP Nouveau: make sure the Group Front Page customizer control exists

When the Groups component is not active, the Group Front page customizer control is not available. To avoid a JavaScript error and play nicer with the customizer we need to check this control is available before manipulating it.

Props r-a-y, cyberwani

Fixes #7934 (Trunk)

File:

• trunk/src/bp-templates/bp-nouveau/js/customizer.js (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/js/customizer.js

@@ -5 +5 @@
 ( function( wp, $ ) {
 
-    if ( undefined === typeof wp.customizer ) {
+    if ( 'undefined' === typeof wp.customize ) {
         return;
     }
 
-    $( document ).ready( function() {
+    wp.customize.bind( 'ready', function() {
+        var groupFrontPage = wp.customize.control( 'group_front_page' ),
+            userFrontPage  = wp.customize.control( 'user_front_page' );
 
         // If the Main Group setting is disabled, hide all others
-        $( wp.customize.control( 'group_front_page' ).selector ).on( 'click', 'input[type=checkbox]', function( event ) {
-            var checked = $( event.currentTarget ).prop( 'checked' ), controller = $( event.delegateTarget ).prop( 'id' );
+        if ( 'undefined' !== typeof groupFrontPage ) {
+            $( groupFrontPage.selector ).on( 'click', 'input[type=checkbox]', function( event ) {
+                var checked = $( event.currentTarget ).prop( 'checked' ), controller = $( event.delegateTarget ).prop( 'id' );
 
-            _.each( wp.customize.section( 'bp_nouveau_group_front_page' ).controls(), function( control ) {
-                if ( control.selector !== '#' + controller ) {
-                    if ( true === checked ) {
-                        $( control.selector ).show();
-                    } else {
-                        $( control.selector ).hide();
+                _.each( wp.customize.section( 'bp_nouveau_group_front_page' ).controls(), function( control ) {
+                    if ( control.selector !== '#' + controller ) {
+                        if ( true === checked ) {
+                            $( control.selector ).show();
+                        } else {
+                            $( control.selector ).hide();
+                        }
                     }
-                }
+                } );
             } );
-        } );
+        }
 
         // If the Main User setting is disabled, hide all others
-        $( wp.customize.control( 'user_front_page' ).selector ).on( 'click', 'input[type=checkbox]', function( event ) {
-            var checked = $( event.currentTarget ).prop( 'checked' ), controller = $( event.delegateTarget ).prop( 'id' );
+        if ( 'undefined' !== typeof userFrontPage ) {
+            $( userFrontPage.selector ).on( 'click', 'input[type=checkbox]', function( event ) {
+                var checked = $( event.currentTarget ).prop( 'checked' ), controller = $( event.delegateTarget ).prop( 'id' );
 
-            _.each( wp.customize.section( 'bp_nouveau_user_front_page' ).controls(), function( control ) {
-                if ( control.selector !== '#' + controller ) {
-                    if ( true === checked ) {
-                        $( control.selector ).show();
-                    } else {
-                        $( control.selector ).hide();
+                _.each( wp.customize.section( 'bp_nouveau_user_front_page' ).controls(), function( control ) {
+                    if ( control.selector !== '#' + controller ) {
+                        if ( true === checked ) {
+                            $( control.selector ).show();
+                        } else {
+                            $( control.selector ).hide();
+                        }
                     }
-                }
+                } );
             } );
-        } );
+        }
 
         $( 'ul#customize-control-group_nav_order, ul#customize-control-user_nav_order' ).sortable( {
@@ -60 +66 @@
             }
         } ).disableSelection();
-
     } );