Skip to:
Content

BuddyPress.org

Opened 17 months ago

Closed 16 months ago

Last modified 16 months ago

#7896 closed defect (bug) (fixed)

Legacy: Activity stream's "Load More" button doesn't work

Reported by: r-a-y Owned by: r-a-y
Milestone: 3.2.0 Priority: normal
Severity: major Version: 3.0.0
Component: Templates Keywords: has-patch commit
Cc:

Description

If you have the Legacy template pack enabled, the activity stream's "Load More" button does not work.

See:
https://buddypress.org/support/topic/activity-load-more-not-working/
https://buddypress.org/support/topic/bp-activity-oldestpage-pagination-cookie-bug-on-page-reload/

The problem is due to the bp-activity-oldestpage cookie being removed from initialization in #7699.

I'm not sure how to address this without either reintroducing the cookie (which we don't want to do) or adding some changes to the javascript.

Attachments (2)

7896.01.patch (744 bytes) - added by r-a-y 17 months ago.
7896.02.patch (2.1 KB) - added by boonebgorges 16 months ago.

Download all attachments as: .zip

Change History (10)

@r-a-y
17 months ago

#1 @r-a-y
17 months ago

  • Keywords has-patch added; needs-patch removed

01.patch always purges the bp-activity-oldestpage cookie, which will enable the "Load More" button to work again.

This allows for the original intention behind #7699 to still be respected (kinda).

#2 @DJPaul
16 months ago

This is a hack. As it removes a cookie, it's not re-introducing creation of the cookie all the time, so it's not against the idea with #7699. If this works, go for it.

We need browser tests to capture these sorts of regressions, and that's something I hope to spearhead through the next few months.

#3 follow-up: @DJPaul
16 months ago

If this cookie is basically reset on each subsequent page load, how about just switching the data storage to a data attribute on the form element somewhere? (Nouveau only - we leave Legacy as it is).

#4 in reply to: ↑ 3 @boonebgorges
16 months ago

Replying to DJPaul:

If this cookie is basically reset on each subsequent page load, how about just switching the data storage to a data attribute on the form element somewhere? (Nouveau only - we leave Legacy as it is).

I like this idea, and I think we should do it in Legacy as well, for GDPR-related reasons. See #7856.

#5 @boonebgorges
16 months ago

7896.02.patch converts it to a simple JS variable. Any reason why this won't work?

#6 @r-a-y
16 months ago

  • Keywords commit added

02.patch works well. Going to commit it!

#7 @r-a-y
16 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12181:

Legacy: Fix activity stream's "Load More" button.

In the bp-legacy template pack, the "Load More" button used to be tied to
the bp-activity-oldestpage cookie. In v3.0, we made steps to remove
this cookie, but this broke activity pagination when used via AJAX (see

This commit outright removes dependencies on the bp-activity-oldestpage
cookie and uses a local variable to track the current activity pagination
number.

Props boonebgorges.

Fixes #7896 (3.x branch).

#8 @r-a-y
16 months ago

In 12182:

Legacy: Fix activity stream's "Load More" button.

In the bp-legacy template pack, the "Load More" button used to be tied to
the bp-activity-oldestpage cookie. In v3.0, we made steps to remove
this cookie, but this broke activity pagination when used via AJAX (see

This commit outright removes dependencies on the bp-activity-oldestpage
cookie and uses a local variable to track the current activity pagination
number.

Props boonebgorges.

See #7896 (trunk).

Note: See TracTickets for help on using tickets.