Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#7699 closed defect (bug) (fixed)

Only set bp-activity-oldestpage when it is used

Reported by: chherbst's profile chherbst Owned by: r-a-y's profile r-a-y
Milestone: 3.0 Priority: normal
Severity: normal Version: 1.0
Component: Templates Keywords:
Cc: chris.p.herbst@…

Description

Under new EU law if a cookie is non-essential it has to be blocked so that a user can opt-in. But if it is essential its ok as long as it's use is detailed on the site. This problem is that buddypress sets this cookie on every page, not only where it is used. If e.g. the activity component is only shown for logged in users, then this cookie is non-essential for not logged in users and should not be set.

The attached patches will set the cookie only when it is used and thus only when it is essential.

This is the information about cookies under EU law.

​http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm

Attachments (2)

0002-fix-initialization-of-bp-activity-oldestpage-cookie.patch​ (903 bytes) - added by chherbst 7 years ago.
0001-outcomment-unneeded-setting-of-cookie.patch​ (1.1 KB) - added by chherbst 7 years ago.

Download all attachments as: .zip

Change History (7)

@chherbst
7 years ago

#1 @chherbst
7 years ago

Please remove Patch 0001-add-missing-button-classes-to-ajax-friend-response.patch. That was added by mistake!

Last edited 7 years ago by chherbst (previous) (diff)

@chherbst
7 years ago

#2 @r-a-y
7 years ago

  • Component changed from Core to Templates
  • Milestone changed from Awaiting Review to 3.0
  • Owner set to r-a-y
  • Status changed from new to reviewing
  • Version changed from 2.9.3 to 1.0

Thanks for the patch, @chherbst.

We'll make sure to address this for v3.0.

#3 @DJPaul
7 years ago

Since you've put it in 3.0 @r-a-y I assume you think the patch is required. I'll let you look into this. :)

#4 @chherbst
7 years ago

  • Cc chris.p.herbst@… added

#5 @djpaul
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 11887:

Templates, Legacy: don't set bp-activity-oldestpage until needed.

Fixes #7699

Props chherbst

Note: See TracTickets for help on using tickets.