Search from filter for bp_nouveau_search_form

[wbcomdesigns]

Inside legacy we have bp_directory_groups_search_form() with filter
which help to modify the search form without modifying template files.

We can keep the same approach for nouveau.
It's called directly without any filter
bp_nouveau_search_form()
inside
buddypress/bp-templates/bp-nouveau/buddypress/common/search-and-filters-bar.php

[DJPaul]

@imath Any ideas how to make this possible?

[imath]

@DJPaul

After a quick look, I think the best is to buffer the template part inside bp_nouveau_search_form(), apply the legacy filter according to the displayed page to finally echo it.

I’ll add a patch to this ticket asap.

[imath]

​7881.patch is my suggestion to fix the issue.

It appears directory search filters are Core components ones, so I guess we should restore them asap, reason why I selected the 3.2.0 milestone.

In the patch, i'm also editing the bp_nouveau_message_search_form() function (unused so far) so that it's also possible to filter the new JS Template for the message search form. This is to restore the bp_message_search_form filter.

@wbcomdesigns can you test the patch and tell us if it fixes your issue ?

[wbcomdesigns]

Thanks, @imath I will update shortly, we need it for our plugin ​https://wordpress.org/plugins/bp-create-group-type/ it extends directory search with group type options.

[vapvarun]

@imath It's working perfectly.

[imath]

Thanks a lot for your feedback @vapvarun 👍 I'll wait for @wbcomdesigns' feedback so we are sure it's fine at 100% 😉

[wbcomdesigns]

@imath confirmed from our end as well, we have also tested with our plugin code.

[imath]

Awesome! Thanks a lot for your tests @wbcomdesigns. @DJPaul @hnla do you think we can improve the patch, or is it good to go ?

[DJPaul]

Looks quite OK to me! Also agreed about 3.2 milestone. Thanks for everyone's work and contributions on this. :)

[imath]

In 12183:

BP Nouveau: bring back search form filters

Although it was already possible to override search form templates, as the following search form filters are not Legacy filters but Core components ones, we are bringing them back into the Nouveau template pack:

• bp_directory_members_search_form
• bp_directory_blogs_search_form
• bp_directory_groups_search_form
• bp_message_search_form

Props wbcomdesigns, DJPaul, vapvarun

See #7881 (branch 3.0)

[imath]

In 12184:

BP Nouveau: bring back search form filters

Although it was already possible to override search form templates, as the following search form filters are not Legacy filters but Core components ones, we are bringing them back into the Nouveau template pack:

• bp_directory_members_search_form
• bp_directory_blogs_search_form
• bp_directory_groups_search_form
• bp_message_search_form

Props wbcomdesigns, DJPaul, vapvarun

Fixes #7881 (trunk)

[hnla]

@imath took a while to figure out what was being addressed here and why, but updated and checked things over and it all looks ok.

@vapvarun are you and @wbcomdesigns actually the same person? :)

[vapvarun]

@hnla Wbcom Designs is our agency and we are training our in-house developers to get familiar with reporting issues and providing patches at trac as @wbcomdesigns and once they feel confident they can submit issues/fixes standalone.

[imath]

Reopening the ticket as the single group search form has not been taken in charge. See #7955

[imath]

In 12206:

BP Nouveau: bring back the single group members search form filter.

This specific filter was forgotten in r12183, the bp_directory_members_search_form filter is also fired when bp_groups_members_template_part() displays the single group members loop.

See #7881
See #7955
(branch 3.0)

[imath]

In 12207:

BP Nouveau: bring back the single group members search form filter.

This specific filter was forgotten in r12184, the bp_directory_members_search_form filter is also fired when bp_groups_members_template_part() displays the single group members loop.

Fixes #7881
See #7955
(trunk)