Skip to:
Content

BuddyPress.org

#7955 closed defect (bug) (fixed)

Group Member search is not working as expected. Nouveau Template.

Reported by: pooja1210 Owned by: imath
Milestone: 3.2.0 Priority: normal
Severity: major Version: 3.0.0
Component: Templates Keywords: has-patch
Cc:

Description

In, group members tab there is search present which is not working as expected.

If search result doesn't match code is shown.

Code shown is as below :

bp_nouveau_user_feedback( 'group-members-none' );

Steps to Reproduce :

1.Go to groups
2.Go to members tab
3.In search field enter invalid data(or any name which is not present in member listing page)
4.Click on search.
5.Observe that, instead of "No members found" message, code is shown.

Note: Issue specifically in Nouveau template.

Attachments (2)

mem-search.png (29.0 KB) - added by pooja1210 14 months ago.
7955.patch (2.4 KB) - added by imath 14 months ago.

Download all attachments as: .zip

Change History (9)

#1 @imath
14 months ago

Hi @pooja1210 Thanks a lot for your feedback, I’ll look at it asap.

#2 @imath
14 months ago

  • Component changed from Core to Templates
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.2.0
  • Owner set to imath
  • Status changed from new to assigned
  • Version set to 3.0.0

I confirm the issue. It's a typo issue. The first part of the 7955.patch is fixing it.

Here's a screen cap of the fix applied :
https://cldup.com/s_XiKjSvsx.png

But this bug revealed a regression from #7881 (my bad!) where I forgot to output the Single group search form + add the back compat filter for the group members search.

So the second part of the patch is fixing it. That's why I'm adding this ticket to the 3.2.0 milestone. Thanks again @pooja1210 for your contribution.

If no objections, I'll commit later tonight (~ 9 to 10 hours from now)

@imath
14 months ago

#3 @pooja1210
14 months ago

@imath

Sure

#4 @imath
14 months ago

In 12206:

BP Nouveau: bring back the single group members search form filter.

This specific filter was forgotten in r12183, the bp_directory_members_search_form filter is also fired when bp_groups_members_template_part() displays the single group members loop.

See #7881
See #7955
(branch 3.0)

#5 @imath
14 months ago

In 12207:

BP Nouveau: bring back the single group members search form filter.

This specific filter was forgotten in r12184, the bp_directory_members_search_form filter is also fired when bp_groups_members_template_part() displays the single group members loop.

Fixes #7881
See #7955
(trunk)

#6 @imath
14 months ago

In 12208:

BP Nouveau: fix a typo into single group members loop template

This typo was causing the user feedback message function name to be output instead of its result when a search was performed in a single group.

Props pooja1210

See #7955 (branch 3.0)

#7 @imath
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12209:

BP Nouveau: fix a typo into single group members loop template

This typo was causing the user feedback message function name to be output instead of its result when a search was performed in a single group.

Props pooja1210

Fixes #7955 (trunk)

Note: See TracTickets for help on using tickets.