Opened 9 years ago
Closed 9 years ago
#7429 closed defect (bug) (fixed)
Update and fix all the NPM things
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 2.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Build/Test Tools | Keywords: | |
| Cc: |
Description
This is a rolling ticket for numerous issues relating to BuddyPress' use of NodeJS and NPM
- Update out of date packages, see table below
- Update Node engine from 6.6.0 to latest 6.x LTS release 6.9.4 in
package.json
- NPM modules in
package.jsonshould only use semantic versioning~minor versions, rather than^major versions, regardless of thenpm-shrinkwrap.jsonfile this will hopefully remove one potential issue, and improve the stability of BPs NodeJS and NPM build tools implementation.
- Manually updating the BuddyPress version in
npm-shrinkwrap.jsonis a task that shouldn't be performed manually, thenpm-shrinkwrap.jsonshould only be generated and/or regenerated by NPM itself.
- Update the codex docs on how to update the
npm-shrinkwrap.jsonfile. Include notes that if usingNPM v4.x to runnpm shrinkwrapwill include development dependencies, whereas in NPM 3.x development dependencies had to be explicitly included by usingnpm shrinkwrap --dev`
- Maybe add https://github.com/mstuart/grunt-shrinkwrap (depends on pending PRs merging)
Available NPM module updates:
| Package | Current | Wanted | Latest | Location |
| grunt-check-dependencies | 0.12.0 | 0.12.0 | 1.0.0 | buddypress |
| grunt-contrib-jshint | 1.0.0 | 1.0.0 | 1.1.0 | buddypress |
| grunt-sass | 1.2.1 | 1.2.1 | 2.0.0 | buddypress |
Change History (16)
This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.
9 years ago
#16
@
9 years ago
- Keywords early removed
- Resolution set to fixed
- Status changed from accepted to closed
Replying to netweb:
- Update out of date packages, see table below
Fixed via [11565] to [11573] changesets
- Update Node engine from 6.6.0 to latest 6.x LTS release 6.9.4 in
package.json
Fixed via [11574]
- NPM modules in
package.jsonshould only use semantic versioning~minor versions, rather than^major versions, regardless of thenpm-shrinkwrap.jsonfile this will hopefully remove one potential issue, and improve the stability of BPs NodeJS and NPM build tools implementation.
Fixed via [11565] to [11574] commits where required
- Manually updating the BuddyPress version in
npm-shrinkwrap.jsonis a task that shouldn't be performed manually, thenpm-shrinkwrap.jsonshould only be generated and/or regenerated by NPM itself.
Fixed via [11575]
- Update the codex docs on how to update the
npm-shrinkwrap.jsonfile. Include notes that if usingNPM v4.x to runnpm shrinkwrapwill include development dependencies, whereas in NPM 3.x development dependencies had to be explicitly included by usingnpm shrinkwrap --dev`
Done, updated codex docs here: https://codex.buddypress.org/prelaunch-checklist/#version-bumps-in-dev
- Maybe add https://github.com/mstuart/grunt-shrinkwrap (depends on pending PRs merging)
Let's use package-lock.json as part of npm v5.x.x, new ticket for this coming shortly
That's everything, marking this ticket now as fixed.
Via
npm help shrinkwrapas the docs at https://docs.npmjs.com/cli/shrinkwrap are out of date: