Skip to:
Content

Opened 2 years ago

Closed 2 years ago

#7426 closed enhancement (fixed)

Welcome Screen for 2.8.0

Reported by: mercime Owned by: mercime
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-screenshots
Cc:

Attachments (17)

7426.png (124.1 KB) - added by mercime 2 years ago.
7426.patch (34.5 KB) - added by mercime 2 years ago.
7426.2.patch (35.1 KB) - added by mercime 2 years ago.
7426.3.patch (35.0 KB) - added by slaFFik 2 years ago.
7426.4.patch (34.4 KB) - added by mercime 2 years ago.
Add translator comments for link and code in headline
7426.5.patch (35.1 KB) - added by slaFFik 2 years ago.
Fixing typo (</code>)
7426.5.png (302.4 KB) - added by slaFFik 2 years ago.
pending-accounts.png (15.7 KB) - added by mercime 2 years ago.
props @r-a-y
list-unsubscribe.png (17.4 KB) - added by mercime 2 years ago.
props @r-a-y
twenty-seventeen.png (31.3 KB) - added by mercime 2 years ago.
7426.6.patch (13.5 KB) - added by mercime 2 years ago.
7426-welcome-screen.png (291.8 KB) - added by mercime 2 years ago.
7426.7.patch (13.5 KB) - added by mercime 2 years ago.
7426.8.patch (13.6 KB) - added by boonebgorges 2 years ago.
7426.9.patch (13.7 KB) - added by slaFFik 2 years ago.
7426.10.patch (15.0 KB) - added by mercime 2 years ago.
7426-welcome-screen.2.png (292.1 KB) - added by mercime 2 years ago.

Download all attachments as: .zip

Change History (42)

#1 @DJPaul
2 years ago

  • Milestone changed from 2.8 to Future Release

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


2 years ago

#3 @boonebgorges
2 years ago

  • Milestone changed from Future Release to 2.8

@mercime
2 years ago

#4 @mercime
2 years ago

  • Keywords has-patch has-screenshots added

First pass - patch and screenshot for the Welcome Screen.

@mercime
2 years ago

#5 @mercime
2 years ago

We could replace at least 2 features/dashicons with screenshots: Twenty Seventeen companion stylesheet and the List-Unsubscribe in header if someone can provide the screenshot for the List-Unsuscribe at least 800px x 500px. Thanks :D

#6 @slaFFik
2 years ago

I would say "BuddyPress has many new improvements that you will enjoy".

@mercime
2 years ago

#7 @mercime
2 years ago

@slaFFik New patch includes the change per your comment as well as the appropriate link to the BP Codex article about requiring PHP 5.3 as of BP 2.8

#8 follow-up: @r-a-y
2 years ago

Thanks for building the Welcome Screen as always, mercime!

As for the headlining feature - "Modernize codebase for BP REST API". Since the BP REST API is in development, I don't think we should reference "BP REST API" in the main header; it's fine to mention it in the supporting paragraph though. I don't know what else to call the header without seeming develop-y.

For other features, I think the profile fields display before user activation on the "Users > Manage Signups" admin page is a decent enough feature to highlight. See #7261.

Also, I'm not sure what the "Provide global fields across all profiles" feature is. Do you have a link to the ticket where this was implemented?

I think we could trim down on a few of the items as well. The PHPMailer and bp_activity_do_heartbeat() ones are not that big to warrant featuring, but that's just my opinion.

Last edited 2 years ago by r-a-y (previous) (diff)

#9 follow-up: @hnla
2 years ago

Modernising The Codebase ( PHP version requirement 5.3 )
In an ongoing process of Scheduled migration of legacy code to modern standards and techniques, and one of the steps required for the current BP REST API project and for new features moving forward, BuddyPress 2.8 will require at least PHP 5.3, this update to php requirements will allow us to build better stronger more secure code and greatly benefit developers and users now and in the future.

or something like that?

#10 @hnla
2 years ago

Think you should move the accessibility up to the main section:

Accessibility enhancements
Further improvements for templates to aid in accessibity requirements...

#11 in reply to: ↑ 8 @mercime
2 years ago

Replying to r-a-y:

Thanks for building the Welcome Screen as always, mercime!

Thanks for your feedback as always @r-a-y :D

As for the headlining feature - "Modernize codebase for BP REST API". Since the BP REST API is in development, I don't think we should reference "BP REST API" in the main header; it's fine to mention it in the supporting paragraph though. I don't know what else to call the header without seeming develop-y.

I'm afraid I had my marketing hat on with the teaser for the BP REST API as one reason for PHP 5.3 on the road to modernizing the codebase as the headline ;)

Perhaps something like "Requiring PHP 5.3 to Modernize Codebase" instead?

For other features, I think the profile fields display before user activation on the "Users > Manage Signups" admin page is a decent enough feature to highlight. See #7261.

+100

Also, I'm not sure what the "Provide global fields across all profiles" feature is. Do you have a link to the ticket where this was implemented?

Hmm, can't find it at this moment, what the ... :( Geez.
Will delete this.

I think we could trim down on a few of the items as well. The PHPMailer and bp_activity_do_heartbeat() ones are not that big to warrant featuring, but that's just my opinion.

The PHPMailer was in the Beta 1 release post and can delete the heartbeat.

#12 in reply to: ↑ 9 @mercime
2 years ago

Replying to hnla:

Modernising The Codebase ( PHP version requirement 5.3 )

In an ongoing process of Scheduled migration of legacy code to modern standards and techniques, and one of the steps required for the current BP REST API project and for new features moving forward, BuddyPress 2.8 will require at least PHP 5.3, this update to php requirements will allow us to build better stronger more secure code and greatly benefit developers and users now and in the future.

Thanks @hnla.

Re Accessibility improvements: Thank you. But honestly, it should stay where it is right now. I wasn't able to do enough this cycle due to unforseen circumstances...

#13 @mercime
2 years ago

So on the table:

  • Redo the headline feature
  • Add "Users > Manage Signups" to features
  • Remove PHPMailer from feature
  • Remove Heartbeat from feature
  • Remove "Provide global fields across all profiles" from feature.

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


2 years ago

@slaFFik
2 years ago

#15 @hnla
2 years ago

it's nit picking a little but...

More helpful "Activate Pending Accounts" screen

to

A more helpful "Activate Pending Accounts" screen

?

#16 follow-up: @slaFFik
2 years ago

@hnla
In this case some other titles should be updated as well. Also, a and the are often omitted in news titles etc for various reasons (catchy, shorter etc). So what about sticking to this?

Last edited 2 years ago by slaFFik (previous) (diff)

#17 in reply to: ↑ 16 @hnla
2 years ago

Replying to slaFFik:

@hnla
In this case some other titles should be updated as well. Also, a and the are often omitted in news titles etc for various reasons (catchy, shorter etc). So what about sticking to this?

Yep fair enough, and true often are omitted. Leave as is.

@mercime
2 years ago

Add translator comments for link and code in headline

@slaFFik
2 years ago

Fixing typo (</code>)

@slaFFik
2 years ago

#18 follow-up: @hnla
2 years ago

<div class="clear"></div>

?????

#19 in reply to: ↑ 18 @mercime
2 years ago

Replying to hnla:

<div class="clear"></div>

?????

Why? :D

@mercime
2 years ago

props @r-a-y

@mercime
2 years ago

props @r-a-y

@mercime
2 years ago

#20 @mercime
2 years ago

In 11423:

Update stylesheets for the BP 2.8 Welcome Screen.

See #7426.

#21 @mercime
2 years ago

7426.6.patch renders the new layout per 7426-welcome-screen.png which includes some edits and additions.

Attached screenshots used for the Welcome Screen:
pending-accounts.png
list-unsubscribe.png
twenty-seventeen.png

This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.


2 years ago

#23 @mercime
2 years ago

In 11424:

Add images for BP 2.8 Welcome Screen.

See #7426.

@mercime
2 years ago

@boonebgorges
2 years ago

@slaFFik
2 years ago

@mercime
2 years ago

#24 @mercime
2 years ago

@boonebgorges Thank you for your awesome edits 🥉

@slaFFik Thanks for updating the alt value for the 2017 stylesheets 🎊

7426.10.patch with additional styles.

Let's commit this already.

#25 @mercime
2 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11425:

Update Welcome Screen for BuddyPress 2.8.

Props slaFFik, r-a-y, hnla, boonebgorges, mercime.
Fixes #7426.

Note: See TracTickets for help on using tickets.