Skip to:
Content

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#7425 closed defect (bug) (fixed)

XProfile: use filterable field input name in radio/checkbox field type

Reported by: Offereins Owned by: offereins
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords:
Cc: lmoffereins@…

Description

Perhaps there is a good reason, but currently the radio and checkbox profile fields do not use the filterable bp_get_the_profile_field_input_name() for their input options name attribute. Using this template tag requires the $field global variable, but the docblock of the edit_field_options_html() field type method requires its usage within the profile template, so that should be covered:

Must be used inside the {@link bp_profile_fields()} template loop.

Since the replacement of the current $field_id value is equivalent to that of the template tag, no obvious damage will be done. The benefit of template parity and filter options with other field types is evident. Are there any objections to this fix?

Attachments (1)

7425.patch (1.6 KB) - added by Offereins 16 months ago.

Download all attachments as: .zip

Change History (5)

@Offereins
16 months ago

#1 @DJPaul
16 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release

Your patch removes the [] that gets PHP's $_POST handling to parse into an array. :)

#2 @offereins
16 months ago

  • Owner set to offereins
  • Resolution set to fixed
  • Status changed from new to closed

In 11400:

XProfile: use filtered template tag for checkbox/radio input names.

The field options structure in the checkbox and radio field types didn't
use bp_get_the_profile_field_input_name() for the input names. This
commit brings those types in line with the other field types using
filtered field template tags.

Fixes #7425.

#3 @Offereins
16 months ago

  • Keywords needs-patch removed

#4 @Offereins
16 months ago

  • Milestone changed from Future Release to 2.8
Note: See TracTickets for help on using tickets.