Add View link for users on BP Signups page

[slaFFik]

BuddyPress signups page in admin area should have a link to user profile on front-end. Otherwise it's rather complicated to go to user profile and check, what fields were selected by user.

I'm talking about this page:
/wp-admin/users.php?page=bp-signups

I propose to add a View link next to the current "Activate | Email | Delete".
OR
Make Username column values be linked not to Activate action, but to the user profile.

What do other devs think?

[espellcaste]

+1

[r-a-y]

This is a good idea.

However, pending signups are saved in the wp_signups DB table and are not actually users yet.

So we cannot view these users on the frontend without a bit of refactoring of the URI router so member lookups would also check the signups table. Profile information would also need to be filled in from the meta column of the wp_signups table as well.

Perhaps when you click on the username, you can view the userdata from within the same admin interface? I think this is a decent compromise.

Moving to "Awaiting Review" for some more feedback.

[r-a-y]

info.patch adds the profile data to the "Activate Pending Accounts" screen.

When you click on the username on the "Users > Manage Signups" page, you can now view all filled in extended profile fields (see attached screenshot above). Hopefully, this is a decent alternative to viewing the profile on the frontend.

I haven't tested all xprofile field types with this, so this could use some more testing.

[DJPaul]

Hey, @r-a-y, I agree with what you say. I like the screenshot. Let's 2.8 it.

[DJPaul]

Let's keep this easy and just show name/email. Patch is fairly close.

[r-a-y]

Let's keep this easy and just show name/email.

I disagree. Even if we add rudimentary support for each profile field type here, it would be better than nothing.

The following support forum thread also asks for all profile fields to be shown:
​https://buddypress.org/support/topic/how-to-view-pending-signup-profile-fields/

And I am tempted to agree with the person who started the thread.

[slaFFik]

I agree with @r-a-y, it's much better (and not so big overhead) to do it properly (imo) from the 1st attempt - display all profile fields.
That's very important for community managers. I personally constantly facing the need of this thing on my own small community, and others in that linked forum thread too.

[boonebgorges]

I agree that we should be showing everything.

It'd be nice if BP_XProfile_Field (or _Field_Type) had a simple way to fetch a display-safe value that was specific to the field. But in the meantime, I think we can handle nearly all types of fields by dealing properly with arrays and by stripping slashes. (Things like HTML in rich-text fields will be escaped, but IMO this is a feature rather than a bug.) See 7261.diff​.

[DJPaul]

Looking quickly at the patch:

<li><?php printf( '<em>%1$s</em> - %2$s', esc_html__( 'Display Name', 'buddypress' ), esc_html__( $signup->user_name ) ) ; ?></li> 

Doesn't look correctly translatable. I think the placeholders need to be in the translatable string.

[r-a-y]

What if we used a <table> instead of a list to display this data?

That way, we wouldn't have ugly translatable strings here.

[r-a-y]

table.patch implements my thoughts from comment:13.

We display the pending signup data as a table to prevent using bad, translatable strings as mentioned in comment:12. View the above image to see what the patch looks like.

[boonebgorges]

Yeah, let's go for it.

[r-a-y]

In 11406:

Users Admin: Show profile field data on "Activate Pending Accounts" page.

This commit now displays the profile field data that the pending user
filled in so an administrator can make a better decision as to whether to
activate the user or not.

Props r-a-y, slaFFik, boonebgorges, DJPaul.

Fixes #7261.

[r-a-y]

In 11422:

After [11406], add RTL CSS for "Activate Pending Accounts" screen.

Props netweb.

See #7261.