Skip to:

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7261 closed enhancement (fixed)

Add View link for users on BP Signups page

Reported by: slaffik's profile slaFFik Owned by: r-a-y's profile r-a-y
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.0
Component: Administration Keywords: has-patch dev-feedback

Description (last modified by slaFFik)

BuddyPress signups page in admin area should have a link to user profile on front-end. Otherwise it's rather complicated to go to user profile and check, what fields were selected by user.

I'm talking about this page:

I propose to add a View link next to the current "Activate | Email | Delete".
Make Username column values be linked not to Activate action, but to the user profile.

What do other devs think?

Attachments (5)

2016-09-16_145549.png (5.7 KB) - added by r-a-y 7 years ago. (2.1 KB) - added by r-a-y 7 years ago.
7261.diff (2.9 KB) - added by boonebgorges 7 years ago.
activate-table.png (6.2 KB) - added by r-a-y 7 years ago.
7261.table.patch (3.5 KB) - added by r-a-y 7 years ago.

Download all attachments as: .zip

Change History (23)

#1 @slaFFik
7 years ago

  • Description modified (diff)

#3 @r-a-y
7 years ago

  • Component changed from Registration to Administration
  • Keywords needs-patch added
  • Milestone changed from 2.7 to Awaiting Review

This is a good idea.

However, pending signups are saved in the wp_signups DB table and are not actually users yet.

So we cannot view these users on the frontend without a bit of refactoring of the URI router so member lookups would also check the signups table. Profile information would also need to be filled in from the meta column of the wp_signups table as well.

Perhaps when you click on the username, you can view the userdata from within the same admin interface? I think this is a decent compromise.

Moving to "Awaiting Review" for some more feedback.

Last edited 7 years ago by r-a-y (previous) (diff)

#4 @r-a-y
7 years ago

  • Keywords has-patch added; needs-patch removed

info.patch adds the profile data to the "Activate Pending Accounts" screen.

When you click on the username on the "Users > Manage Signups" page, you can now view all filled in extended profile fields (see attached screenshot above). Hopefully, this is a decent alternative to viewing the profile on the frontend.

I haven't tested all xprofile field types with this, so this could use some more testing.

Last edited 7 years ago by r-a-y (previous) (diff)

7 years ago

#5 @DJPaul
7 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 2.8

Hey, @r-a-y, I agree with what you say. I like the screenshot. Let's 2.8 it.

#6 @DJPaul
7 years ago

  • Owner set to r-a-y
  • Status changed from new to assigned

#7 @DJPaul
7 years ago

  • Keywords needs-patch added; has-patch removed

Let's keep this easy and just show name/email. Patch is fairly close.

#8 @r-a-y
7 years ago

  • Keywords dev-feedback added

Let's keep this easy and just show name/email.

I disagree. Even if we add rudimentary support for each profile field type here, it would be better than nothing.

The following support forum thread also asks for all profile fields to be shown:

And I am tempted to agree with the person who started the thread.

#9 @slaFFik
7 years ago

I agree with @r-a-y, it's much better (and not so big overhead) to do it properly (imo) from the 1st attempt - display all profile fields.
That's very important for community managers. I personally constantly facing the need of this thing on my own small community, and others in that linked forum thread too.

7 years ago

#10 @boonebgorges
7 years ago

  • Keywords dev-feedback removed

I agree that we should be showing everything.

It'd be nice if BP_XProfile_Field (or _Field_Type) had a simple way to fetch a display-safe value that was specific to the field. But in the meantime, I think we can handle nearly all types of fields by dealing properly with arrays and by stripping slashes. (Things like HTML in rich-text fields will be escaped, but IMO this is a feature rather than a bug.) See 7261.diff.

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.

7 years ago

#12 @DJPaul
7 years ago

Looking quickly at the patch:

<li><?php printf( '<em>%1$s</em> - %2$s', esc_html__( 'Display Name', 'buddypress' ), esc_html__( $signup->user_name ) ) ; ?></li> 

Doesn't look correctly translatable. I think the placeholders need to be in the translatable string.

#13 @r-a-y
7 years ago

  • Version set to 2.0

What if we used a <table> instead of a list to display this data?

That way, we wouldn't have ugly translatable strings here.

7 years ago

#14 @r-a-y
7 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

table.patch implements my thoughts from comment:13.

We display the pending signup data as a table to prevent using bad, translatable strings as mentioned in comment:12. View the above image to see what the patch looks like.

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.

7 years ago

7 years ago

#16 @boonebgorges
7 years ago

Yeah, let's go for it.

#17 @r-a-y
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11406:

Users Admin: Show profile field data on "Activate Pending Accounts" page.

This commit now displays the profile field data that the pending user
filled in so an administrator can make a better decision as to whether to
activate the user or not.

Props r-a-y, slaFFik, boonebgorges, DJPaul.

Fixes #7261.

#18 @r-a-y
7 years ago

In 11422:

After [11406], add RTL CSS for "Activate Pending Accounts" screen.

Props netweb.

See #7261.

Note: See TracTickets for help on using tickets.