Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7358 closed enhancement (fixed)

Accessibility: Use semantic button elements instead of empty links in Profile visibility settings

Reported by: mercime's profile mercime Owned by: mercime's profile mercime
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords: has-patch has-screenshots
Cc:

Description

The profile visibility links in the following screens: Profile > Edit, Registration, and wp-admin Users - Member > Extended Profile should be buttons instead of empty links for proper semantics and accessibility.

  • Change empty link to button element
  • Close empty link to button element

Patch and screenshots coming up.

Attachments (3)

7358.patch​ (3.5 KB) - added by mercime 8 years ago.
profile-field-visibility.png​ (46.4 KB) - added by mercime 8 years ago.
Before and After using the Twenty Sixteen theme
7358.2.patch​ (3.5 KB) - added by mercime 8 years ago.

Download all attachments as: .zip

Change History (9)

@mercime
8 years ago

@mercime
8 years ago

Before and After using the Twenty Sixteen theme

#1 @mercime
8 years ago

  • Component changed from Core to Extended Profile
  • Keywords has-patch has-screenshots added

#2 @dontdream
8 years ago

@mercime: please note there is a surviving href="#" inside the last <button> element.

#3 @mercime
8 years ago

@dontdream Thank you :) Updated patch coming up.

@mercime
8 years ago

#4 @DJPaul
8 years ago

Patch LGTM.

#5 @mercime
8 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11246:

Accessibility: Use <button> elements in Profile visibility settings.

Replace empty links <a href="#"> with semantic <button> elements for
semantics and accessibility.

Fixes #7358.

#6 @mercime
8 years ago

In 11410:

Credits: Add @dontdream to contributor list.
Thank you.

See #7358.

Note: See TracTickets for help on using tickets.