Changeset 11246

Timestamp:

11/24/2016 06:42:49 PM (10 years ago)

Author:

mercime

Message:

Accessibility: Use <button> elements in Profile visibility settings.

Replace empty links <a href="#"> with semantic <button> elements for
semantics and accessibility.

Fixes #7358.

Location:

trunk/src

Files:

• bp-templates/bp-legacy/buddypress/members/register.php (modified) (2 diffs)
• bp-templates/bp-legacy/buddypress/members/single/profile/edit.php (modified) (2 diffs)
• bp-xprofile/classes/class-bp-xprofile-user-admin.php (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/buddypress/members/register.php

@@ -190 +190 @@
                                                                         );
                                                                         ?>
-                                                                        <a href="#" class="visibility-toggle-link"><?php _ex( 'Change', 'Change profile field visibility level', 'buddypress' ); ?></a>
+                                                                        <button type="button" class="visibility-toggle-link"><?php _ex( 'Change', 'Change profile field visibility level', 'buddypress' ); ?></button>
                                                                 </p>
 
@@ -200 +200 @@
 
                                                                         </fieldset>
-                                                                        <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
+                                                                        <button type="button" class="field-visibility-settings-close"><?php _e( 'Close', 'buddypress' ) ?></button>
 
                                                                 </div>

trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php

@@ -60 +60 @@
                                                 );
                                                 ?>
-                                                <a href="#" class="visibility-toggle-link"><?php _e( 'Change', 'buddypress' ); ?></a>
+                                                <button type="button" class="visibility-toggle-link"><?php _e( 'Change', 'buddypress' ); ?></button>
                                         </p>
 
@@ -70 +70 @@
 
                                                 </fieldset>
-                                                <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
+                                                <button type="button" class="field-visibility-settings-close"><?php _e( 'Close', 'buddypress' ) ?></button>
                                         </div>
                                 <?php else : ?>

trunk/src/bp-xprofile/classes/class-bp-xprofile-user-admin.php

@@ -398 +398 @@
                                                 <?php if ( $can_change_visibility ) : ?>
 
-                                                        <a href="#" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></a>
+                                                        <button type="button" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></button>
 
                                                 <?php endif; ?>
@@ -412 +412 @@
 
                                                         </fieldset>
-                                                        <a class="button field-visibility-settings-close" href="#"><?php esc_html_e( 'Close', 'buddypress' ); ?></a>
+                                                        <button type="button" class="button field-visibility-settings-close"><?php esc_html_e( 'Close', 'buddypress' ); ?></button>
                                                 </div>