Ticket #7358: 7358.patch

src/bp-templates/bp-legacy/buddypress/members/register.php

@@ -189 +189 @@
                                                                                 '<span class="current-visibility-level">' . bp_get_the_profile_field_visibility_level_label() . '</span>'
                                                                         );
                                                                         ?>
-                                                                        <a href="#" class="visibility-toggle-link"><?php _ex( 'Change', 'Change profile field visibility level', 'buddypress' ); ?></a>
+                                                                        <button type="button" class="visibility-toggle-link"><?php _ex( 'Change', 'Change profile field visibility level', 'buddypress' ); ?></button>
                                                                 </p>
 
                                                                 <div class="field-visibility-settings" id="field-visibility-settings-<?php bp_the_profile_field_id() ?>">
@@ -199 +199 @@
                                                                                 <?php bp_profile_visibility_radio_buttons() ?>
 
                                                                         </fieldset>
-                                                                        <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
+                                                                        <button type="button" class="field-visibility-settings-close"><?php _e( 'Close', 'buddypress' ) ?></button>
 
                                                                 </div>
                                                         <?php else : ?>

src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php

@@ -59 +59 @@
                                                         '<span class="current-visibility-level">' . bp_get_the_profile_field_visibility_level_label() . '</span>'
                                                 );
                                                 ?>
-                                                <a href="#" class="visibility-toggle-link"><?php _e( 'Change', 'buddypress' ); ?></a>
+                                                <button type="button" class="visibility-toggle-link"><?php _e( 'Change', 'buddypress' ); ?></button>
                                         </p>
 
                                         <div class="field-visibility-settings" id="field-visibility-settings-<?php bp_the_profile_field_id() ?>">
@@ -69 +69 @@
                                                         <?php bp_profile_visibility_radio_buttons() ?>
 
                                                 </fieldset>
-                                                <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
+                                                <button type="button" class="field-visibility-settings-close"><?php _e( 'Close', 'buddypress' ) ?></button>
                                         </div>
                                 <?php else : ?>
                                         <div class="field-visibility-settings-notoggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">

src/bp-xprofile/classes/class-bp-xprofile-user-admin.php

@@ -397 +397 @@
 
                                                 <?php if ( $can_change_visibility ) : ?>
 
-                                                        <a href="#" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></a>
+                                                        <button type="button" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></button>
 
                                                 <?php endif; ?>
                                         </p>
@@ -411 +411 @@
                                                                 <?php bp_profile_visibility_radio_buttons(); ?>
 
                                                         </fieldset>
-                                                        <a class="button field-visibility-settings-close" href="#"><?php esc_html_e( 'Close', 'buddypress' ); ?></a>
+                                                        <button type="button" class="button field-visibility-settings-close" href="#"><?php esc_html_e( 'Close', 'buddypress' ); ?></button>
                                                 </div>
 
                                         <?php endif; ?>