Skip to:

Opened 7 years ago

Closed 7 years ago

#7345 closed enhancement (fixed)

Clean up BP_Core_Nav_Item

Reported by: slaffik's profile slaFFik Owned by: slaffik's profile slaFFik
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.6.0
Component: Navigation Keywords: has-patch commit

Description (last modified by slaFFik)

As we are moving to PHP 5.3, we can deprecate some code.
Regarding BP_Core_Nav_Item - bp-core/classes/class-bp-core-nav-item.php

It has an if statement to use ArrayObject which was introduced in PHP 5.3, so we can remove its else statement for BuddyPress 2.8.

See attached patch, where I also cleaned up BP_Nav_Item => BP_Core_Nav_Item mentions in code comments.

Attachments (1)

7345.patch (2.6 KB) - added by slaFFik 7 years ago.

Download all attachments as: .zip

Change History (6)

7 years ago

#1 @slaFFik
7 years ago

  • Description modified (diff)

#2 @slaFFik
7 years ago

  • Keywords has-patch added

#3 @DJPaul
7 years ago

  • Owner changed from imath to slaFFik
  • Status changed from new to assigned

@slaFFik This patch looks good! Well done for spotting the documentation errors. I'll leave this patch for you to commit once you're able to.

#4 @DJPaul
7 years ago

  • Keywords commit added

#5 @slaffik
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11290:

Clean up BP_Core_Nav_Item.

Remove PHP 5.2 wrapper from BP_Core_Nav_Item class, as we moved to PHP 5.3. Also clean up appropriate related code comments to properly reflect this class name.

Fixes #7345.

Note: See TracTickets for help on using tickets.