Opened 8 years ago
Closed 8 years ago
#7345 closed enhancement (fixed)
Clean up BP_Core_Nav_Item
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | 2.6.0 |
Component: | Navigation | Keywords: | has-patch commit |
Cc: |
Description (last modified by )
As we are moving to PHP 5.3, we can deprecate some code.
Regarding BP_Core_Nav_Item
- bp-core/classes/class-bp-core-nav-item.php
It has an if statement to use ArrayObject
which was introduced in PHP 5.3, so we can remove its else
statement for BuddyPress 2.8.
See attached patch, where I also cleaned up BP_Nav_Item => BP_Core_Nav_Item mentions in code comments.
Attachments (1)
Change History (6)
Note: See
TracTickets for help on using
tickets.
@slaFFik This patch looks good! Well done for spotting the documentation errors. I'll leave this patch for you to commit once you're able to.