Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7340 closed enhancement (fixed)

bp_get_group_permalink() should use bp_get_group_slug() internally.

Reported by: dcavins Owned by: slaffik
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7.2
Component: Groups Keywords: has-patch commit
Cc: dcavins

Description

Currently, you have to filter both the group permalink and the slug if you want to filter the slug. The permalink should be built using the filtered slug.

I can't think of any downsides to this change. Please let me know if you have concerns.

Attachments (1)

7340.1.diff (686 bytes) - added by dcavins 3 years ago.
Use the filtered slug to build the permalink.

Download all attachments as: .zip

Change History (3)

@dcavins
3 years ago

Use the filtered slug to build the permalink.

#1 @DJPaul
3 years ago

  • Keywords commit added

Yes, looks perfect.

#2 @slaffik
3 years ago

  • Owner set to slaffik
  • Resolution set to fixed
  • Status changed from new to closed

In 11291:

New filter for bp_get_group_permalink().

Currently, we have to filter both the group permalink and the slug if we want to filter the slug. The permalink should be built using the filtered slug.

Props dcavins.
Fixes #7340.

Note: See TracTickets for help on using tickets.