Missing colon in string

[SGr33n]

Hi people,

In the following string

​https://translate.wordpress.org/projects/wp-plugins/buddypress/dev/it/default?filters[status]=either&filters[original_id]=2290779&filters[translation_id]=39879704

I suppose there is a missing colon on the row:
To learn more about the group, visit group.url.
Should it be:
To learn more about the group, visit: group.url.

Is it right?

Thanks!

[danbp]

I controlled the french translation to see if there is a similar issue.

I found that almost all email text containing quotes are marked as fuzzy.

Ie. the original string shows hello "group"
the string marked as fuzzy shows hello "group"

On other strings using quotes, i have "word" in original and translation.

I don't thing that the double point is the issue but the quotes used immediatly after. And this in not all strings using quotes.

Example here: ​https://translate.wordpress.org/projects/wp-plugins/buddypress/dev/fr/default?page=15

[danbp]

Double checked translation and found another possible reason.

I haven't see that first (f... contrast) but they are blank spaces in the original strings. Look after "accepted" !

Your membership request for the group "{{group.name}}" has been accepted.↵ ↵ To view the group, visit: {{{group.url }}}

The fuzzy one

Votre demande d'adhésion au groupe "{{group.name}}" a été acceptée. Voir le groupe: {{{group.url }}}

[slaFFik]

Quotes change is caused by the ticket #6949 and r10956.

[danbp]

Would ENT_NOQUOTES do the trick with htmlentities() ?

I tested following string with htmlentities() here: ​https://en.functions-online.com/htmlentities.html

string htmlentities ( string $str [, int $quote_style ] [, string $charset ] )

String:

{{poster.name}} replied to one of your comments:

"{{usermessage}}"

Quote_style: ENT_NOQUOTES

Charset: UTF-8

This returns a correct value.
BuddyPress doesn't use nowhere htmlentities or htmlspecialchars.
bbPress use htmlspecialchars in a few files.

[DJPaul]

I think this is off-topic -- the reporter asked about whether a string should have a colon in it. Right?

In reply to @SGr33n, I wouldn't call this a bug, but if you think the sentence is better that way, I've no problems changing it, as long as we're consistent with the other emails.

[SGr33n]

I see that every "visit url" has a colon, this looks the only one whithout, just for consistence. Sorry for this is not a bug, I will report this on the slack channel the next time.

[DJPaul]

OK, let's add the colon into the string for consistency. I'll get this done in 2.8, but anyone is welcome to provide a patch for easy props, it should be pretty trivial. :)

[djpaul]

In 11285:

Emails: fix consistent use of colon before links in notifications.

Fixes #7252

Props danbp, sanket.parmar