Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#6949 closed defect (bug) (fixed)

Quotes inconsistency in emails texts

Reported by: slaFFik Owned by: djpaul
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.5.0
Component: Emails Keywords: needs-patch good-first-bug
Cc:

Description

In emails text we can see usage of both " and " in the same context.

Example:

<a href="{{{profile.url}}}">{{requesting-user.name}}</a> wants to join the group &quot;{{group.name}}&quot;

and

{{poster.name}} replied to one of your comments:

"{{usermessage}}"

Change History (4)

#1 @DJPaul
4 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

#2 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.7

The issue reported is mixing up the strings used for HTML emails and plaintext emails. However, while looking at this, we noticed that some of the plain text emails had these HTML entities in them, so I'll remove those.

#3 @djpaul
3 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10956:

Emails: remove HTML entities from plaintext emails.

Fixes #6949

#4 @Offereins
3 years ago

@djpaul Would translators not be confused when they have to 'translate' slashed quotes? I'm not aware of any WP/BP standards for this type of translatable strings, but I can imagine that one might translate them literally as slashed quotes - which would result in undesired situations. Or does it depend on the type of translation tool?

Note: See TracTickets for help on using tickets.