Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6950 closed defect (bug) (fixed)

String translation problem in different languages

Reported by: slaFFik Owned by: imath
Milestone: 2.5.1 Priority: high
Severity: normal Version: 2.5.0
Component: Activity Keywords: has-patch commit
Cc:

Description

This may be a not valid translation because of the string structure.

https://plugins.trac.wordpress.org/browser/buddypress/tags/2.5.0/bp-activity/bp-activity-functions.php#L561

$post_type_activity->comments_tracking->front_filter = sprintf( __( '%s comments', 'buddypress' ), $post_type_object->labels->singular_name );

Different languages have different rules when using 2+ nouns together. Russian has various affixes that greatly depends on a word gender, German can combine words in 1 etc.

Attachments (1)

6950.patch (738 bytes) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.


5 years ago

#2 @DJPaul
5 years ago

  • Priority changed from normal to high

#3 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.5.1

This may be for 2.5.2 depending on complexity/time required. We need to re-phrase this string, and remove the placeholder. On Slack, @slaFFik suggested we could add this as another special string that we use when registering post types (e.g. https://codex.buddypress.org/plugindev/post-types-activities/).

#4 @slaFFik
5 years ago

__( 'Item comments', 'buddypress' ) can be another solution, proposed by @imath (https://wordpress.slack.com/archives/buddypress/p1457520073001832)

#5 @imath
5 years ago

  • Keywords has-patch added

It's already possible to override this value by defining the bp_activity_comments_front_filter label when registering the post type : see https://codex.buddypress.org/plugindev/post-types-activities/#2-add-comments-tracking-feature-during-the-post-type-registration

So i guess __( 'Item comments', 'buddypress' ) might be the best solution. FYI this string is a fallback in case the bp_activity_comments_front_filter label is not available for the post type.

@imath
5 years ago

#6 @DJPaul
5 years ago

  • Keywords commit added

Looks good, nice simple fix.

#7 @imath
5 years ago

In 10645:

Post Type Comments: Improve i18n for the activity front-end filter.

See #6950 (branch 2.5)

#8 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10646:

Post Type Comments: Improve i18n for the activity front-end filter.

Fixes #6950 (trunk)

Note: See TracTickets for help on using tickets.