Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#6911 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings - "Go back and try again."

Reported by: ramiy Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description

see the attached patch.

Attachments (2)

6911.patch (2.3 KB) - added by ramiy 3 years ago.
6911.2.patch (2.3 KB) - added by ramiy 3 years ago.
better patch

Download all attachments as: .zip

Change History (10)

@ramiy
3 years ago

#1 @DJPaul
3 years ago

  • Milestone changed from Awaiting Review to 2.5

#2 @DJPaul
3 years ago

  • Milestone changed from 2.5 to Under Consideration

I don't like this patch because it splits paragraphs into multiple phrases. I expect there may be languages where people want to re-order the sentences, or continue to have just one.

#3 @ramiy
3 years ago

This strings can be splitted.

The first string is a notice. The second string is call to action.

Re-ordering have no sense. In any language.

Usually, first you tell the user what's wrong (not found), and than you call to action (go back).

#4 @ramiy
3 years ago

@DJPaul

If you examine the code, you will see that in the first translation string is already splited into two strings.

You can say that this patch is unifying the other strings.

@ramiy
3 years ago

better patch

#5 @boonebgorges
3 years ago

In 10672:

Group admin: Improve logic when deciding whether to show "No group found" message.

See #6911.

Fixes #6975.

#6 @boonebgorges
3 years ago

  • Milestone changed from Under Consideration to 2.6

I don't love the haphazard splitting of paragraphs just to avoid a bit of markup, but this is a case where I don't think it matters.

#7 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10673:

Remove markup from translatable strings on admin screens.

Props ramiy.
Fixes #6911.

#8 @DJPaul
3 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.