Opened 9 years ago
Closed 9 years ago
#6912 closed defect (bug) (fixed)
BP Email prevents the activation email to be resent by the admin / BP Email fails when used in an Administration screen
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.5 | Priority: | high |
Severity: | blocker | Version: | |
Component: | Administration | Keywords: | commit |
Cc: |
Description
If you try to resend the activation email from the Signups Administration screen, although the feedback message tells you the email was sent, it's actually not sent.
That's because the BP Email feature relies on the bp_locate_template()
function to get the template, and we cannot load a template into an administration screen. I had a similar issue with the Avatar UI (#6348) and we finally used require
.
But i don't think we can do this here, as this would prevent template overrides...
To be sure that was the problem, i've used the mail-admin.patch and i confirm using it, the email is sent successfully.
Attachments (2)
Change History (11)
#1
@
9 years ago
- Summary changed from BP Email prevents the activation email to be resend by the admin / BP Email fails when used in an Administration screen to BP Email prevents the activation email to be resent by the admin / BP Email fails when used in an Administration screen
This ticket was mentioned in Slack in #buddypress by imath. View the logs.
9 years ago
#4
@
9 years ago
I think your patch is OK. Thanks for finding this issue and working on a fix.
Maybe we can revisit in a future release *why* this function should not load the template inside wp-admin -- is that something we're doing somewhere? Or is it a decision from old code?
#6
@
9 years ago
Actually maybe make the filter name resemble the function name more, maybe bp_locate_template_and_load
??
#7
@
9 years ago
6912.patch uses bp_locate_template_and_load
for the filter name.
is that something we're doing somewhere? Or is it a decision from old code?
It's something i had to face for the avatar UI, but i don't know why we restrict template parts loading inside Administration screens.
Is
WP_USE_THEMES
not set in wp-admin?