Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6582 closed defect (bug) (fixed)

WP 4.3 changed CSS breaks layout of Welcome Screen sections

Reported by: mercime Owned by: djpaul
Milestone: 2.3.3 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

WP 4.3 trunk, BP 2.4 trunk

Attached screenshot shows the broken layouts of “The Finer Points” and “Under the Hood” sections of BP's Welcome Screen Page as compared to https://buddypress.trac.wordpress.org/attachment/ticket/6433/welcome-screen.png.

There are different ways to address this issue, depending on whether the plan to redesign the Welcome Screen page for BP 2.4.0 will push through. One solution is add inline styles, another is to enqueue a stylesheet for this panel. Need decision for either way or to work on another option.

Attachments (3)

welcome-screen-borked.png (81.4 KB) - added by mercime 4 years ago.
6582.diff (1.4 KB) - added by mercime 4 years ago.
6582.2.diff (3.3 KB) - added by mercime 4 years ago.

Download all attachments as: .zip

Change History (11)

#1 @espellcaste
4 years ago

I'm not sure about the future plans for the Welcome Screen, but I think enqueueing a stylesheet seems better in this case.

#2 @mercime
4 years ago

  • Component changed from API to Component - Core
  • Keywords has-patch added

Attached patch adds the minimum styles needed in common.css and common-rtl.css to bring the layout of the two sections back to former glory as seen in https://buddypress.trac.wordpress.org/attachment/ticket/6433/welcome-screen.png

Thanks for your feedback @espellcaste.

Last edited 4 years ago by mercime (previous) (diff)

@mercime
4 years ago

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


4 years ago

#4 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to 2.3.3

If we add these to BP 2.3.3, they won't cause problems on older WP versions? Because it's the same markup? Right?

#5 @mercime
4 years ago

@DJPaul Yes, it's the same markup and won't cause problems in at least WP 4.2 as I used core's style from that version in attached patch. Speaking of which, preparing another patch to include mobile-friendly style as well.

#6 @mercime
4 years ago

Attached patch includes mobile-friendly styles.

@mercime
4 years ago

#7 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10063:

Welcome Screen: backport CSS from WP 4.3 welcome screen to fix ours in WP 4.4+.

Props mercime, fixes #6582 (trunk).

#8 @djpaul
4 years ago

In 10064:

Welcome Screen: backport CSS from WP 4.3 welcome screen to fix ours in WP 4.4+.

Props mercime, fixes #6582 (2.3 branch).

Note: See TracTickets for help on using tickets.