Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6581 closed enhancement (fixed)

WP 4.3 H1 heading in the admin and new class

Reported by: mercime Owned by: mercime
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch dev-feedback has-screenshots
Cc:

Description

For accessibility, h1 heading has replaced h2 heading in admin screens. In addition, a new class .page-title-action has replaced .add-new-h2:hover to "Use a less element-specific class name for links within page titles." https://core.trac.wordpress.org/ticket/31650

Patch coming up.

Attachments (5)

6581.diff (7.0 KB) - added by mercime 5 years ago.
First pass at BP admin panels
6581.patch (6.8 KB) - added by mercime 5 years ago.
6581-alt.patch (8.3 KB) - added by mercime 5 years ago.
bp-settings.gif (49.2 KB) - added by mercime 5 years ago.
Settings > BuddyPress with new heading, BuddyPress Settings
6581-h2-to-h1.png (16.4 KB) - added by mercime 5 years ago.
Comparison - BP h1 on WP 4.2 and on WP trunk

Download all attachments as: .zip

Change History (18)

@mercime
5 years ago

First pass at BP admin panels

#1 @mercime
5 years ago

  • Keywords has-patch added
  • Type changed from defect (bug) to enhancement

#2 @DJPaul
5 years ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to Under Consideration

#3 @DJPaul
5 years ago

Yo team, I'm not sure what we decided here wrt. minimum supported version of WordPress. To steal a phrase Boone coined, I'd like to optimise for the latest version of WordPress -- I don't care if changing h2s to h1s for old versions of WordPress makes stuff look weird.

@mercime
5 years ago

@mercime
5 years ago

#4 @mercime
5 years ago

Attached 6581.patch replaces h2 page heading with an h1 level heading in each of the following BuddyPress admin panels:

  • Activity
    • Activity -> Edit
  • Groups
    • Group -> Edit
    • Group -> Delete
  • Users > Manage Signups
    • Manage Signups - Activate link -> Activate Pending Accounts
    • Manage Signups - Email link -> Resend Activation Emails
    • Manage Signups - Delete link -> Delete Pending Accounts
  • Users > Profile Fields
    • Profile Fields - Add New Field link -> Add New Field
    • Profile Fields - Edit Field link -> Edit Field
    • Profile Fields - Add New Field Group link -> Add New Field Group
    • Profile Fields - Edit Group link -> Edit Field Group
  • Tools BuddyPress

Notes:

  1. wp-admin > About BuddyPress already has h1 heading.
  2. wp-admin > Users > Your Profile page already has h1 heading.

Attached 6581-alt.patch combines 6581.patch above with a proposal to add an h1 level heading, "BuddyPress Settings", to the Settings > BuddyPress panels.

@mercime
5 years ago

Settings > BuddyPress with new heading, BuddyPress Settings

#5 @mercime
5 years ago

  • Keywords has-screenshots added

@mercime
5 years ago

Comparison - BP h1 on WP 4.2 and on WP trunk

#6 @mercime
5 years ago

  • Milestone changed from Under Consideration to 2.5

6581.patch needs to be committed in order to bump lower level headings in #6698, #6699, #6700, #6701, #6702, and upcoming tickets for the rest of BP dashboard screens.

We will address the "Add xxx" links within page title heading tags in a new ticket when the WP a11y team moves those out of the <h1>tags per their initial discussions in slack/trac tickets for WP 4.5.0. At this time, there is still style support for links in WP 4.4.0-trunk.

The proposal for a page title per 6581-alt.patch for the Settings > BuddyPress panels will also be addressed in an upcoming ticket specifically for those screens.

#7 @mercime
5 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10357:

A11y: h1 headings for page titles of BuddyPress wp-admin screens.

Fixes #6581.

#8 @mercime
5 years ago

In 10358:

A11y: Adjust heading structure in About BuddyPress > Credits.

Fixes #6698. See #6581.

#9 @mercime
5 years ago

In 10359:

A11y: Adjust heading structure in Activity > Edit.

Fixes #6699. See #6581.

#10 @mercime
5 years ago

In 10360:

A11y: Adjust heading structure in Group > Edit.

Fixes #6700. See #6581.

#11 @mercime
5 years ago

In 10361:

A11y: Adjust heading structure in Profile Fields > Add New Field
and Edit Field.

Fixes #6701. See #6581.

#12 @mercime
5 years ago

In 10362:

A11y: Adjust heading structure in Profile Fields > Add New Field Group
and Edit Field Group.

Fixes #6702. See #6581.

#13 @DJPaul
4 years ago

  • Component changed from Component - Any/All to Core
Note: See TracTickets for help on using tickets.