Skip to:

Opened 9 years ago

Closed 9 years ago

#6583 closed defect (bug) (fixed)

bp_friend_requests_item hook should have been inside <div class="item"> div

Reported by: pareshradadiya's profile pareshradadiya Owned by: djpaul's profile djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version: 1.7
Component: Friends Keywords: has-patch needs-testing commit


bp_friend_requests_item is outside the <div class="item"> and it should be inside <div class="item"> like members-loop's bp_directory_members_item

Attachments (1)

6583.diff (1.2 KB) - added by pareshradadiya 9 years ago.
Hook moved inside item div

Download all attachments as: .zip

Change History (6)

9 years ago

Hook moved inside item div

#1 @johnjamesjacoby
9 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.4
  • Version set to 1.7

This looks right. Thanks for the ticket & patch!

#2 @DJPaul
9 years ago

  • Keywords needs-testing added

@mercime or @hnla -- can you give this a once-over sometime?

#3 @hnla
9 years ago

I saw this yesterday - Yes essentially we have outputted friends items grouped inside a div then allow for additional items that fall outside of that group which on the face of it must be wrong.

Only concern is if moving the hook would upset any existing actions but that's more likely to occur moving a hook outside of some existing scope, less likely devs would have written:
.item + .my-hooked-items but is possible!

I would suggest we commit on the basis that it's unlikely to cause issues and always should have been inside the .item div not outside.

We can and will add the change to the codex version template changes page.

#4 @DJPaul
9 years ago

  • Keywords commit added

Thanks hnla

#5 @djpaul
9 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10241:

Legacy templates: move action in friend request template.

The bp_friend_requests_item action has been positioned incorrectly
outside the .item div since BP-Default. This change moves it inside
the div.

Fixes #6583

Props pareshradadiya

Note: See TracTickets for help on using tickets.