User domains don't resolve correctly with BP_ENABLE_ROOT_PROFILES when Members page is not top-level

[boonebgorges]

See #6475 for previous report.

Steps to reproduce:

• define( 'BP_ENABLE_ROOT_PROFILES', true ); in wp-config.php
• Make your Members page a child of another page
• Try to visit the domain of a specific user (eg, example.com/boone)

Expected: you see the user's page
Actual: you see the Members directory

[boonebgorges]

6477.diff​ ports the fix for the problem from r-a-y's patch on #6475 ​https://buddypress.trac.wordpress.org/attachment/ticket/6475/6475.01.patch, and adds a unit test. (The rest of his suggested fixes in that patch are performance-related, and probably deserve a separate ticket, since they're much more expansive.)

[r-a-y]

The rest of his suggested fixes in that patch are performance-related, and probably deserve a separate ticket, since they're much more expansive.

I wouldn't really say "much more expansive", but I get your point :) I've ported over the additional performance tweak into 02.patch, just so it isn't lost.

[espellcaste]

I had this problem recently. I solved not putting it as a child of another page. But wasn't sure it was a bug in BuddyPress or somewhere in my code or another plugin.

[boonebgorges]

Looks good to me.

[r-a-y]

In 10212:

URI: Allow root profiles to work when the 'Members' page is nested.

Previously, if the Members page was nested as a child of another page, the
root profiles feature - define( 'BP_ENABLE_ROOT_PROFILES', true ); - did
not work. This commit fixes this and includes a unit test.

Commit also adds a minor performance tweak when a root profile is detected.

Props r-a-y, boonebgorges.

Fixes #6477.