Changeset 10212

Timestamp:

10/08/2015 04:52:31 AM (11 years ago)

Author:

r-a-y

Message:

URI: Allow root profiles to work when the 'Members' page is nested.

Previously, if the Members page was nested as a child of another page, the
root profiles feature - define( 'BP_ENABLE_ROOT_PROFILES', true ); - did
not work. This commit fixes this and includes a unit test.

Commit also adds a minor performance tweak when a root profile is detected.

Props r-a-y, boonebgorges.

Fixes #6477.

Location:

trunk

Files:

• src/bp-core/bp-core-catchuri.php (modified) (2 diffs)
• tests/phpunit/testcases/routing/root-profiles.php (modified) (1 diff)

trunk/src/bp-core/bp-core-catchuri.php

@@ -241 +241 @@
         // Rejig the offset
         if ( !empty( $slug ) && ( 1 < count( $slug ) ) ) {
-                array_pop( $slug );
-                $uri_offset = count( $slug );
+                // Only offset if not on a root profile. Fixes issue when Members page is nested.
+                if ( false === $root_profile ) {
+                        array_pop( $slug );
+                        $uri_offset = count( $slug );
+                }
         }
 
@@ -265 +268 @@
                         // Are we viewing a specific user?
                         if ( $after_member_slug ) {
+                                // If root profile, we've already queried for the user
+                                if ( $root_profile instanceof WP_User ) {
+                                        $bp->displayed_user->id = $root_profile->ID;
+
                                 // Switch the displayed_user based on compatibility mode
-                                if ( bp_is_username_compatibility_mode() ) {
+                                } elseif ( bp_is_username_compatibility_mode() ) {
                                         $bp->displayed_user->id = (int) bp_core_get_userid( urldecode( $after_member_slug ) );
+
                                 } else {
                                         $bp->displayed_user->id = (int) bp_core_get_userid_from_nicename( $after_member_slug );

trunk/tests/phpunit/testcases/routing/root-profiles.php

@@ -43 +43 @@
         }
 
+        /**
+         * @ticket BP6475
+         */
+        public function test_member_permalink_when_members_page_is_nested_under_wp_page() {
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'page',
+                        'post_name' => 'foo',
+                ) );
+
+                $members_page = get_page_by_path( 'members' );
+                wp_update_post( array(
+                        'ID' => $members_page->ID,
+                        'post_parent' => $p,
+                ) );
+
+                $domain = home_url( $this->u->user_nicename );
+                $this->go_to( $domain );
+
+                $this->assertTrue( bp_is_user() );
+                $this->assertTrue( bp_is_my_profile() );
+                $this->assertEquals( $this->u->ID, bp_displayed_user_id() );
+        }
+
         public function test_member_activity_page() {
                 $url = home_url( $this->u->user_nicename ) . '/' . bp_get_activity_slug();