Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6455 closed defect (bug) (fixed)

allow the duplicate notications

Reported by: ganesh641 Owned by: boonebgorges
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.2.1
Component: Toolbar & Notifications Keywords: good-first-bug has-patch
Cc: ganesh87.641@…

Description

Needed apply_filter to allow_duplicate notification in the "bp_notifications_add_notification" function.

Attachments (1)

6455.diff (865 bytes) - added by pareshradadiya 4 years ago.
wp_parse_args is replaced with bp_parse_args. So now we can use "bp_before_notifications_params_parse_args" or "bp_after_notifications_params_parse_args"

Download all attachments as: .zip

Change History (8)

#1 @ganesh641
4 years ago

  • Cc ganesh87.641@… added

#2 @boonebgorges
4 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 2.4
  • Priority changed from highest to normal

Better: let's use bp_parse_args() in bp_notifications_add_notification(), so that any of the params can be filtered.

#3 @ganesh641
4 years ago

bp_parse_args() is used to get value as filtered parameter for the template page. How do we used bp_parse_args() in bp_notifications_add_notification() function.

#4 @mercime
4 years ago

#6459 dupllicate

#5 @ganesh641
4 years ago

Any batch available?

@pareshradadiya
4 years ago

wp_parse_args is replaced with bp_parse_args. So now we can use "bp_before_notifications_params_parse_args" or "bp_after_notifications_params_parse_args"

#6 @pareshradadiya
4 years ago

  • Keywords has-patch added; needs-patch removed

#7 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9992:

Use bp_parse_args() in bp_notifications_add_notification().

This allows devs to modify default arguments, including the 'allow_duplicate'
check.

Props pareshradadiya, ganesh641.
Fixes #6455.

Note: See TracTickets for help on using tickets.