Opened 9 years ago
Closed 9 years ago
#6456 closed defect (bug) (fixed)
Remove redundant ARIA role="main" from BP legacy template files
Reported by: | mercime | Owned by: | johnjamesjacoby |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | 1.7 |
Component: | Appearance - Template Pack | Keywords: | has-patch 2nd-opinion |
Cc: |
Description
WP 4.2.2 and BP trunk
We have ARIA role="main" markups in BP template files which should not there because all WordPress core themes from Twenty Fifteen down to Twenty Ten already have that ARIA role in respective page.php and relevant files. The same goes for Automattic's _s theme which continue to serve as a starter theme to many themes in the WP Theme Repository. There should only be one main landmark role per page. http://www.w3.org/TR/wai-aria/roles#main
This was a carry-over when template files were ported from the old BP Default theme to the legacy folder for the theme compatibility feature.
Attached is a screenshot of a BP page with 2 extra role="main" instances
Attached are patches for the respective files in the activity, blogs, forums, groups, and member folders.
Attachments (6)
Change History (9)
#1
@
9 years ago
- Keywords 2nd-opinion added
- Milestone changed from Awaiting Review to 2.3
Good catch, mercime.
I am completely comfortable squeezing these into 2.3. Anyone opposed?
#2
@
9 years ago
It is a good catch, I'm for squeezing this in, it's not a feature change, should not upset any theme styling (very unlikely anyone would ever style on this attr
In 2.4 we'll start to address more of these concerns hopefully with some new templates but anything we can catch and update now the better.
3 in one page example