Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6454 closed defect (bug) (fixed)

BP Companion Stylesheet - comments in css files should be updated

Reported by: imath Owned by: hnla
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

Since r9883 we're using the template name instead of the stylesheet name to let people override the companion stylesheet from their child theme. But in the bp-templates/bp-legacy/buddypress/css/twentyfifteen.css stylesheet, the comment at the top is saying :

If you are running as a child theme of twentyfifteen and wish to use
this stylesheet then please copy it to buddypress/css/ or community/css/
in your child theme root and rename the file to match your child theme name
i.e. in child theme named 'twentyfifteen-child', twentyfifteen.css would become
'twentyfifteen-child.css

If you do so, the /themes/twentyfifteen-child/buddypress/css/twentyfifteen-child.css will not override the bundle stylesheet, it needs to be /themes/twentyfifteen-child/buddypress/css/twentyfifteen.css for it to work.

I've also noticed the bp-templates/bp-legacy/buddypress/css/twentyfourteen.css was not including this comment. Maybe it would be a good idea to :

  • include the comment just like it's the case for twentyfifteen
  • or create a page in the codex and add a link to it in both companion stylesheet, so that if the rule is changing, we can deal with it from this codex page..

Change History (4)

#1 @imath
5 years ago

  • Owner set to hnla
  • Status changed from new to assigned

#2 @hnla
5 years ago

@imath - oops yes indeed comments are incorrect now - I'll look to update them for both sheets and also add a link to a codex page for more detailed info for good measure.

Great spot, thanks for highlighting this.

#3 @hnla
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9895:

Update twentyfourteen/twentyfifteen companion styles

Commit updates and corrects stylefile header comments.

  • Re-write overload file guidance for child themes
  • Copy comment block to 2014 sheet
  • Add readmore link to newly created codex page for more info

Fixes #6454 Props imath

#4 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.