#6454 closed defect (bug) (fixed)
BP Companion Stylesheet - comments in css files should be updated
Reported by: | imath | Owned by: | hnla |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | |
Cc: |
Description
Since r9883 we're using the template name instead of the stylesheet name to let people override the companion stylesheet from their child theme. But in the bp-templates/bp-legacy/buddypress/css/twentyfifteen.css
stylesheet, the comment at the top is saying :
If you are running as a child theme of twentyfifteen and wish to use
this stylesheet then please copy it to buddypress/css/ or community/css/
in your child theme root and rename the file to match your child theme name
i.e. in child theme named 'twentyfifteen-child', twentyfifteen.css would become
'twentyfifteen-child.css
If you do so, the /themes/twentyfifteen-child/buddypress/css/twentyfifteen-child.css
will not override the bundle stylesheet, it needs to be /themes/twentyfifteen-child/buddypress/css/twentyfifteen.css
for it to work.
I've also noticed the bp-templates/bp-legacy/buddypress/css/twentyfourteen.css
was not including this comment. Maybe it would be a good idea to :
- include the comment just like it's the case for twentyfifteen
- or create a page in the codex and add a link to it in both companion stylesheet, so that if the rule is changing, we can deal with it from this codex page..
@imath - oops yes indeed comments are incorrect now - I'll look to update them for both sheets and also add a link to a codex page for more detailed info for good measure.
Great spot, thanks for highlighting this.