Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6203 closed defect (bug) (fixed)

bp_get_group_has_avatar and $_FILES check

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Groups Keywords: has-patch commit
Cc:

Description

bp_get_group_has_avatar() does a $_FILES check that looks pretty useless given the only usage of this function we currently have in core. I think Boone commented on it in r8244. Can we safely remove this?

Attachments (1)

6203.01.patch (834 bytes) - added by johnjamesjacoby 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 follow-up: @boonebgorges
5 years ago

Yeah, I don't see any harm in removing it. Might look over the logs to see if there's a clue as to why it was first added, but I say rip it out.

#2 in reply to: ↑ 1 @johnjamesjacoby
5 years ago

Replying to boonebgorges:

Yeah, I don't see any harm in removing it. Might look over the logs to see if there's a clue as to why it was first added, but I say rip it out.

Logs show this came only as part of a huge refactoring for 1.1, where lots of dual purpose functions were consolidated. I suspect this was just cross-fire copy/paste.

#3 @johnjamesjacoby
5 years ago

  • Keywords has-patch commit added; needs-patch 2nd-opinion removed
  • Milestone changed from Under Consideration to 2.3

#4 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9464:

Remove $_FILES check in bp_get_group_has_avatar(). This function is only used in 1 place, and has not interacted with avatar uploads since 1.1.0. Fixes #6203.

#5 @johnjamesjacoby
5 years ago

In 9465:

PHPDoc block and column align an array in bp_get_group_has_avatar(). See #6203.

Note: See TracTickets for help on using tickets.