Opened 10 years ago
Closed 7 years ago
#6204 closed enhancement (maybelater)
Move bp_loggedin_register_page_redirect_to into helper function
Reported by: | johnjamesjacoby | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 1.5 |
Component: | Registration | Keywords: | needs-patch, 2nd-opinion, good-first-bug, trac-tidy-2018 |
Cc: |
Description
Right now the bp_loggedin_register_page_redirect_to
filter is manually called in 2 separate places, making it somewhat confusing to learn 1 filter is called in two places.
Extracting this into a function would eliminate duplicate filter documentation, and funnel filters and functionality down into 1 standard place where it's more obvious what function and filter is responsible for bouncing a logged in user away from the registration page to another destination.
Change History (4)
#3
@
7 years ago
- Keywords trac-tidy-2018 added
We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.
Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.
If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.
For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/
Related, the
bp_loggedin_activate_page_redirect_to
filter is only used in one place. Should this be part ofcanonical_url
also?