Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6017 closed enhancement (fixed)

Adding new folders to svn:ignore

Reported by: slaFFik Owned by: djpaul
Priority: normal Milestone: 2.2
Component: Core Version:
Severity: normal Keywords: has-patch
Cc:

Description

.idea (it has the same value as .DS_Store, but for PHPStorm)
src/vendor (it has the same - almost - value as build, generated on local machines via composer install based on composer.json).

Attachments (1)

ignore.patch (572 bytes ) - added by slaFFik 12 years ago.

Download all attachments as: .zip

Change History (10)

@slaFFik
12 years ago

#1 @slaFFik
12 years ago

  • Type defect (bug)task

#2 @slaFFik
12 years ago

  • Keywords has-patch added

#3 @slaFFik
12 years ago

  • Milestone Awaiting Review2.2

#4 @DJPaul
12 years ago

  • Keywords reporter-feedback added
  • Type taskenhancement

How are you getting Composer to give you a src/vendor folder?

The way I imagined all the Composer stuff working was that, after the 2.2 release, we'd register https://plugins.svn.wordpress.org/buddypress/tags/2.2 etc on Packagist, and Packagist would then provide the release builds of BuddyPress (i.e. the contents of the build folder generated by the Grunt task, not src). If you're using Composer with https://buddypress.svn.wordpress.org/, that's not intended (but harmless enough if it works I guess).

#5 @djpaul
12 years ago

In 9144:

Add more paths to the .gitignore file for some IDEs and Composer.

See #6017

#6 @djpaul
12 years ago

  • Owner set to djpaul
  • Resolutionfixed
  • Status newclosed

In 9145:

Add more paths to svn:ignore for some IDEs and Composer.

Fixes #6017, props slaFFik

#7 @slaFFik
12 years ago

The initial problem was that I didn't have /build/ directory, more info in #6015.

And as I saw composer.json file in src/ folder, I just entered composer install in that src folder. Boone said that he works right from it, without build, mainly, so I thought this a good move. And that command created me a src/vendor folder. Now I understand, that build with composer.json file will be on packagist.

#8 @slaFFik
12 years ago

  • Keywords reporter-feedback removed

#9 @DJPaul
12 years ago

Understood; thanks for the patches!

Note: See TracTickets for help on using tickets.