Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#6018 closed enhancement (wontfix)

composer.lock should be in the repo

Reported by: slaffik's profile slaFFik Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc: tjnowell

Description

As composer will be added to BuddyPress, composer.lock should be in the repo, more info here and here.

This means that anyone who sets up the project will download the exact same version of the dependencies.

(c) getcomposer.org

Attachments (1)

6018.patch (3.6 KB) - added by slaFFik 9 years ago.

Download all attachments as: .zip

Change History (9)

@slaFFik
9 years ago

#1 @slaFFik
9 years ago

  • Keywords has-patch added

#2 @slaFFik
9 years ago

  • Milestone changed from Awaiting Review to 2.2

#3 @DJPaul
9 years ago

  • Cc tjnowell added
  • Keywords 2nd-opinion added
  • Milestone changed from 2.2 to Awaiting Review
  • Type changed from task to enhancement

Copying in Tom for a second opinion, who is my Composer guru. Tom -- should we include this?

#4 @TJNowell
9 years ago

I don't see what benefit this gives, since the only dependency is the composer installer, and we always want the latest version of that. Perhaps on tagged versions/branches if we added any further dependencies it would be useful

#5 @DJPaul
9 years ago

  • Keywords has-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Let's not do this for now. We can revisit if we start adding extra dependencies in the future. Thanks for the feedback Tom.

#6 @DJPaul
9 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#7 @slaFFik
7 years ago

  • Keywords 2nd-opinion removed
  • Resolution set to wontfix
  • Status changed from reopened to closed

Since no extra dependencies have been added (for 2 years), I'm closing this ticket as wontfix.

#8 @DJPaul
7 years ago

I think once we start using Composer (probably for the developer version; probably upcoming testing tools) we'll definitely add a lockfile then.

Note: See TracTickets for help on using tickets.