Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#6018 closed enhancement (wontfix)

composer.lock should be in the repo

Reported by: slaFFik Owned by:
Priority: normal Milestone:
Component: Core Version:
Severity: normal Keywords:
Cc: tjnowell

Description

As composer will be added to BuddyPress, composer.lock should be in the repo, more info ​here and ​here.

This means that anyone who sets up the project will download the exact same version of the dependencies.

(c) getcomposer.org

Attachments (1)

6018.patch​ (3.6 KB ) - added by slaFFik 12 years ago.

Download all attachments as: .zip

Change History (9)

@slaFFik
12 years ago

#1 @slaFFik
12 years ago

  • Keywords has-patch added

#2 @slaFFik
12 years ago

  • Milestone Awaiting Review → 2.2

#3 @DJPaul
12 years ago

  • Cc tjnowell added
  • Keywords 2nd-opinion added
  • Milestone 2.2 → Awaiting Review
  • Type task → enhancement

Copying in Tom for a second opinion, who is my Composer guru. Tom -- should we include this?

#4 @TJNowell
12 years ago

I don't see what benefit this gives, since the only dependency is the composer installer, and we always want the latest version of that. Perhaps on tagged versions/branches if we added any further dependencies it would be useful

#5 @DJPaul
12 years ago

  • Keywords has-patch removed
  • Milestone Awaiting Review
  • Resolution → invalid
  • Status new → closed

Let's not do this for now. We can revisit if we start adding extra dependencies in the future. Thanks for the feedback Tom.

#6 @DJPaul
12 years ago

  • Resolution invalid
  • Status closed → reopened

#7 @slaFFik
10 years ago

  • Keywords 2nd-opinion removed
  • Resolution → wontfix
  • Status reopened → closed

Since no extra dependencies have been added (for 2 years), I'm closing this ticket as wontfix.

#8 @DJPaul
10 years ago

I think once we start using Composer (probably for the developer version; probably upcoming testing tools) we'll definitely add a lockfile then.

Note: See TracTickets for help on using tickets.