Opened 10 years ago
Closed 10 years ago
#5997 closed defect (bug) (fixed)
Highlighting BP parent page in WP menu
Reported by: | r-a-y | Owned by: | r-a-y |
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Core | Keywords: | commit |
Cc: |
Description
This is a follow-up to #5810.
The changes I recommended to bp_core_load_template()
in ticket:5810#comment:3 to reinstate the BP page lookup was not the right way to highlight the page menu and created an edge-case bug (don't ask).
01.patch
is the proper way to deal with highlighting the parent BP page in WP menus and also fixes problems with highlighting the parent BP page when root profiles is turned on (this never worked before).
Attachments (2)
Change History (10)
#2
@
10 years ago
- Keywords has-patch needs-refresh added
Let's make the checks type-strict and get it in so we can test it.
#4
@
10 years ago
Let's make the checks type-strict and get it in so we can test it.
Are you talking about lines 188 and 190 in bp-core-filters.php
of 01.patch
?
@
10 years ago
02.patch adds another function to handle filtering wp_nav_menu(). The first patch only dealt with wp_page_menu().
Not tested but looks OK (but then so did the last patch on the other ticket) :)