Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#5998 closed enhancement (fixed)

bp-legacy theme. Member groups page select id for groups order

Reported by: lenasterg Owned by: r-a-y
Milestone: 2.2 Priority: lowest
Severity: trivial Version:
Component: Templates Keywords: has-patch needs-testing
Cc:

Description

Similar to https://buddypress.trac.wordpress.org/ticket/5996 ticket.
Different ids for ordering select elements in member's group page and in Groups directory page.
Suggestion to change the element's id in member's group page to "groups-order-by".

Lena

Attachments (1)

groups.php.patch (873 bytes) - added by lenasterg 6 years ago.

Download all attachments as: .zip

Change History (4)

#1 @DJPaul
6 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 2.2
  • Type changed from defect (bug) to enhancement

To copy/paste Boone's comment from that other ticket:

I don't have a problem with making this change. Just need to verify that it doesn't break the AJAX filtering.

#2 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9232:

bp-legacy: For member groups template, use same <select> ID as the groups directory template.

This is done for consistency from a theme developer's perspective.

Props lenasterg. Fixes #5998.

#3 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.