Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#5996 closed enhancement (fixed)

bp-legacy theme. Member blogs order by select id

Reported by: lenasterg Owned by: r-a-y
Milestone: 2.2 Priority: lowest
Severity: trivial Version:
Component: Templates Keywords: has-patch
Cc:

Description

Hi.
I noticed that in /src/bp-templates/bp-legacy/buddypress/members/single/blogs.php the select for blogs ordering has different id (#blogs-all) than the same functionality select (#blogs-order-by) in /src/bp-templates/bp-legacy/buddypress/blogs/index.php.
Further more the id #blogs-all is used in /src/bp-templates/bp-legacy/buddypress/blogs/index.php for the <li> of "All Sites".
So, it is confusing when a theme developer tries to apply styling at the "All Sites" <li> or at the blogs "order by" select.

In the attached file, is the suggestion to change the id for the orderind select in /src/bp-templates/bp-legacy/buddypress/members/single/blogs.php to (#blogs-order-by) same as in /src/bp-templates/bp-legacy/buddypress/blogs/index.php

Bests Lena.

Attachments (1)

blogs.php.patch (853 bytes) - added by lenasterg 6 years ago.
Change select id for bp-legacy/buddypress/members/single/blogs.php

Download all attachments as: .zip

Change History (5)

@lenasterg
6 years ago

Change select id for bp-legacy/buddypress/members/single/blogs.php

#1 @boonebgorges
6 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 2.2

I don't have a problem with making this change. Just need to verify that it doesn't break the AJAX filtering.

#2 @r-a-y
6 years ago

  • Keywords needs-testing removed

Tested the change on a user's "Sites" page and the change doesn't affect AJAX.

Going to commit this. Thanks lenasterg!

#3 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 9222:

bp-legacy: For member blogs template, use same <select> ID as the blogs directory template.

This is done for consistency from a theme developer's perspective.

Props lenasterg. Fixes #5996.

#4 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.