bp-legacy theme. Member blogs order by select id

[lenasterg]

Hi.
I noticed that in /src/bp-templates/bp-legacy/buddypress/members/single/blogs.php the select for blogs ordering has different id (#blogs-all) than the same functionality select (#blogs-order-by) in /src/bp-templates/bp-legacy/buddypress/blogs/index.php.
Further more the id #blogs-all is used in /src/bp-templates/bp-legacy/buddypress/blogs/index.php for the <li> of "All Sites".
So, it is confusing when a theme developer tries to apply styling at the "All Sites" <li> or at the blogs "order by" select.

In the attached file, is the suggestion to change the id for the orderind select in /src/bp-templates/bp-legacy/buddypress/members/single/blogs.php to (#blogs-order-by) same as in /src/bp-templates/bp-legacy/buddypress/blogs/index.php

Bests Lena.

[lenasterg]

Change select id for bp-legacy/buddypress/members/single/blogs.php

[boonebgorges]

I don't have a problem with making this change. Just need to verify that it doesn't break the AJAX filtering.

[r-a-y]

Tested the change on a user's "Sites" page and the change doesn't affect AJAX.

Going to commit this. Thanks lenasterg!

[r-a-y]

In 9222:

bp-legacy: For member blogs template, use same <select> ID as the blogs directory template.

This is done for consistency from a theme developer's perspective.

Props lenasterg. Fixes #5996.