Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#5931 closed enhancement (wontfix)

Scripts to footer

Reported by: JibsouX Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

Hellow i'm wondering why buddy press don't respect the standar way of creating a wabsite (css in head js in footer..)

so i search how to put all the script in the wp-footer
if anyone have a lead Tx a lot it will be a good thing to add in the setting : chose where you want to load th scripts !

Tx in advance !

Change History (9)

#1 @DJPaul
5 years ago

  • Keywords reporter-feedback added

Some of our JS is very, very, very old and crusty, so that might be something to do with the "why". :)

Can you paste HTML from your site that shows the JS loaded by BuddyPress that you think we should move into the footer, so that we can see if it's possible.

#2 @DJPaul
5 years ago

  • Component changed from Core to Theme
  • Milestone changed from Awaiting Review to 2.2
  • Priority changed from high to normal

I think this is something we'll keep in mind going forward. I'm hesitant to move everything in case we break something we forget to check. I think we can move the @mentions scripts into the footer, I'll look into that when I update those scripts this release cycle.

#3 @DJPaul
5 years ago

  • Keywords good-first-bug added

First step for an easy contribution is to move the @mentions script into the footer. Then we can tackle all the others one-by-one.

#4 @DJPaul
5 years ago

  • Milestone changed from 2.2 to Future Release

#5 @djpaul
4 years ago

In 9796:

Core: load atwho.js and caret.js in page footer.

The Activity component’s JS that uses these libraries is already set to
enqueue in the page footer, so this should have no consequence to our
existing implementation.

See #5931

#6 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @DJPaul
3 years ago

  • Keywords reporter-feedback good-first-bug removed

Let's look at this after the new template pack is done. That way, we can more easily see what scripts BP core is adding vs. what BP-Legacy was adding, and be able to move/test approprately.

#8 @DJPaul
2 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#9 @DJPaul
2 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.