#5932 closed enhancement (fixed)
Capability for BP_Members_Admin should be "manage_network_users"
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Core | Keywords: | good-first-bug has-patch commit |
Cc: |
Description
The current capability used in BP_Members_Admin is "manage_network_options". It think it would be better to use the "manage_network_users" capability. This would allow more granular access control to the network admin.
This would also require to replace
if ( ! is_super_admin() || empty( $action ) )
on line 1333 with
if ( ! current_user_can( $this->capability ) || empty( $action ) ) {
In my case I use this to allow specific users access to the network user management without giving them full access to all network options. I currently do this by extending the BP_Members_Admin, what seems rather hackish.
Attachments (1)
Change History (8)
#1
@
10 years ago
- Component changed from Members to Roles/Capability
- Milestone changed from Awaiting Review to 2.2
This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.
10 years ago
#5
@
10 years ago
- Keywords commit added
Looks good to me. Since these are largely stuck behind is_super_admin()
checks, breakage should be nonexistent.
Our capability stuff is generally incomplete and probably inconsistent, but we can look into this. :)