Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#5879 closed enhancement (fixed)

"Notify group members" email should contain more useful information

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-refresh
Cc:

Description

When changing the name or description of a group, you have the option of sending an email notification informing group members of the change "Notify group members...". However, the email as it stands is pretty useless. https://buddypress.trac.wordpress.org/browser/tags/2.0.3/bp-groups/bp-groups-notifications.php#L36

I proposing modifying the emails so they look like this:

Group details for the group "foo" were updated: 

* Name changed from "bar" to "foo"
* Description changed from "Old description" to "New description"

To view the group: http://example.com/groups/bar/

See attached patch.

Attachments (1)

5879.patch (3.0 KB) - added by boonebgorges 5 years ago.

Download all attachments as: .zip

Change History (6)

@boonebgorges
5 years ago

#1 @imath
5 years ago

Like it a lot!!

I had the opportunity to look into this area lately and there might be other group changes that might desearve an attention message. I'm thinking of a change of status. If a group that was private becomes public, then i think members should be informed. But that's another ticket story, i think because it would require to intoduce some "transition group status" mechanism and a new notification function. I'll submit another ticket about this.

#2 @DJPaul
5 years ago

Idea sounds good.

I had a quick look at the patch and:

  • I think it'd be improved if it uses LI elements (etc) rather than asterisks for fake bullet points.
  • The __( '* Name changed from "%s" to "%s"', 'buddypress' ) strings should probably have some context to clarify that it's the group name that's changed, not the name of something else.
  • Maybe add a new filter inside groups_notification_group_updated to let other plugins easily add their own "bullet points" for changes of any group functionality that they introduce.

#3 @boonebgorges
5 years ago

Thanks, guys.

I think it'd be improved if it uses LI elements (etc) rather than asterisks for fake bullet points.

Yes, but this is the text of an email. We currently only support plain-text email.

The ( '* Name changed from "%s" to "%s"', 'buddypress' ) strings should probably have some context to clarify that it's the group name that's changed, not the name of something else.
Maybe add a new filter inside groups_notification_group_updated to let other plugins easily add their own "bullet points" for changes of any group functionality that they introduce.

Good ideas. Thanks!

#4 @DJPaul
5 years ago

  • Keywords needs-refresh added

#5 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9226:

Include updated name/description in email notification after a group is updated.

When updating a group's details, there's a checkbox that asks "Notify group
members?". But the notification that goes out does not currently contain any
information about what was changed. The current changeset adds this information
to the email text.

Fixes #5879.

Note: See TracTickets for help on using tickets.