#5878 closed defect (bug) (fixed)
Error message punctuation, try again.
Reported by: | netweb | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | minor | Version: | |
Component: | I18N | Keywords: | has-patch |
Cc: |
Description
Various error messages throughout BuddyPress end with try again.
A dozen of these use try again
and do not include the full stop period at the end of the sentence.
For consistency these should all be the same.
Attachments (2)
Change History (12)
#2
@
10 years ago
Ha! I saw the semi-colons but didn't notice a single comma in any of those strings ;)
This belongs here http://theoatmeal.com/comics/semicolon
#5
@
10 years ago
- Keywords has-patch added; needs-refresh good-first-bug removed
I've tested and it works, have searched for more to do but can't find any... looks ready to commit.
#6
@
10 years ago
All I did in my original patch was add a .
(period) to the end of the sentences and per Boone's comment above there are numerous instances of inconsistencies with ;
(semi-colons) and ,
(commas) used throughout that code, both in my patch and other cases I missed.
e.g.
There was an error when promoting that user, please try again.
<- Comma
There was an error when demoting that user; please try again.'
<- Semi colon
Thus all strings throughout should look something like:
This is the first statement. Please try again.
#7
@
10 years ago
Oh ha, I looked the wrong way and searched for
- Please try again,
- Please try again;
I will take the advice given multiple times and try again!
Thanks. If we're going to make string changes, let's actually make the text good in all cases. Executive decision: "Please try again" should always be a separate sentence - not separated with a semi-colon, and definitely not with a comma.