Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#5878 closed defect (bug) (fixed)

Error message punctuation, try again.

Reported by: netweb Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: minor Version:
Component: I18N Keywords: has-patch
Cc:

Description

Various error messages throughout BuddyPress end with try again.

A dozen of these use try again and do not include the full stop period at the end of the sentence.

For consistency these should all be the same.

Attachments (2)

try-again.diff (6.4 KB) - added by netweb 6 years ago.
try-again.2.diff (29.8 KB) - added by tharsheblows 6 years ago.

Download all attachments as: .zip

Change History (12)

@netweb
6 years ago

#1 @boonebgorges
6 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 2.2

Thanks. If we're going to make string changes, let's actually make the text good in all cases. Executive decision: "Please try again" should always be a separate sentence - not separated with a semi-colon, and definitely not with a comma.

#2 @netweb
6 years ago

Ha! I saw the semi-colons but didn't notice a single comma in any of those strings ;)

This belongs here http://theoatmeal.com/comics/semicolon

#3 @DJPaul
6 years ago

  • Keywords good-first-bug added; has-patch removed

#4 @DJPaul
6 years ago

  • Component changed from Core to Text Changes

#5 @tharsheblows
6 years ago

  • Keywords has-patch added; needs-refresh good-first-bug removed

I've tested and it works, have searched for more to do but can't find any... looks ready to commit.

#6 @netweb
6 years ago

All I did in my original patch was add a . (period) to the end of the sentences and per Boone's comment above there are numerous instances of inconsistencies with ; (semi-colons) and , (commas) used throughout that code, both in my patch and other cases I missed.

e.g.

  • There was an error when promoting that user, please try again. <- Comma
  • There was an error when demoting that user; please try again.' <- Semi colon

Thus all strings throughout should look something like:

  • This is the first statement. Please try again.

#7 @tharsheblows
6 years ago

Oh ha, I looked the wrong way and searched for

  • Please try again,
  • Please try again;

I will take the advice given multiple times and try again!

#8 @tharsheblows
6 years ago

Ok, third (second?) time's the charm. Maybe.

#9 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9190:

Remove some run-on sentences, also some comma splices, they were kind of annoying, they made BuddyPress more annoying to use, this is much better, thanks for using BuddyPress.

Props tharsheblows.
Fixes #5878.

#10 @DJPaul
4 years ago

  • Component changed from Locale - Text Changes to I18N
Note: See TracTickets for help on using tickets.