Ticket #5879: 5879.patch

src/bp-groups/bp-groups-functions.php

@@ -186 +186 @@
         if ( empty( $group_name ) || empty( $group_desc ) )
                 return false;
 
-        $group              = groups_get_group( array( 'group_id' => $group_id ) );
+        $group     = groups_get_group( array( 'group_id' => $group_id ) );
+        $old_group = clone $group;
+
         $group->name        = $group_name;
         $group->description = $group_desc;
 
@@ -194 +196 @@
                 return false;
 
         if ( $notify_members ) {
-                groups_notification_group_updated( $group->id );
+                groups_notification_group_updated( $group->id, $old_group );
         }
 
         do_action( 'groups_details_updated', $group->id );

src/bp-groups/bp-groups-notifications.php

@@ -21 +21 @@
  * @since BuddyPress (1.0.0)
  *
  * @param int $group_id ID of the group.
+ * @param BP_Groups_Group $old_group Group before new details were saved.
  */
-function groups_notification_group_updated( $group_id = 0 ) {
+function groups_notification_group_updated( $group_id = 0, $old_group = null ) {
+
+        $group = groups_get_group( array( 'group_id' => $group_id ) );
+
+        if ( is_a( $old_group, 'BP_Groups_Group' ) ) {
+                $changed = array();
+
+                if ( $group->name !== $old_group->name ) {
+                        $changed[] = sprintf(
+                                __( '* Name changed from "%s" to "%s"', 'buddypress' ),
+                                $old_group->name,
+                                $group->name
+                        );
+                }
+
+                if ( $group->description !== $old_group->description ) {
+                        $changed[] = sprintf(
+                                __( '* Description changed from "%s" to "%s"', 'buddypress' ),
+                                $old_group->description,
+                                $group->description
+                        );
+                }
+        }
+
+        $changed_text = '';
+        if ( ! empty( $changed ) ) {
+                $changed_text = "\n\n" . implode( "\n", $changed );
+        }
 
-        $group    = groups_get_group( array( 'group_id' => $group_id ) );
         $subject  = bp_get_email_subject( array( 'text' => __( 'Group Details Updated', 'buddypress' ) ) );
         $user_ids = BP_Groups_Member::get_group_member_ids( $group->id );
 
@@ -45 +72 @@
                 $settings_link = bp_core_get_user_domain( $user_id ) . $settings_slug . '/notifications/';
 
                 $message = sprintf( __(
-'Group details for the group "%1$s" were updated:
+'Group details for the group "%1$s" were updated: %2$s
 
-To view the group: %2$s
+To view the group: %3$s
 
 ---------------------
-', 'buddypress' ), $group->name, $group_link );
+', 'buddypress' ), $group->name, $changed_text, $group_link );
 
                 $message .= sprintf( __( 'To disable these notifications please log in and go to: %s', 'buddypress' ), $settings_link );