Opened 10 years ago
Closed 10 years ago
#5862 closed defect (bug) (fixed)
activity comment replies problem when bp_activity_current_comment returns false
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | 1.5 |
Component: | Appearance - Template Pack | Keywords: | has-patch commit |
Cc: | shane@… |
Description
BP 2.0.2, WP 3.9.2, Theme 2013, Plugins: just BP
Forum Reference:
http://buddypress.org/support/topic/in-certain-cases-comments-are-not-showing-only-replied-in-my-groups/
Steps to Recreate:
- Create or join a private group
- Create an update in that group
- Go the main activity stream, select 'My Groups' and comment on that update
- The result is that only 'replied' appears.
- Refresh the page - the comment now appears
If debug is on, then Step 4 will show:
'Notice: Trying to get property of non-object in .../wp-content/plugins/buddypress/bp-blogs/bp-blogs-activity.php on line 734'
The problem seems to be that in:
bp-blogs-activity.php > bp_blogs_setup_comment_loop_globals_on_ajax() $comment = bp_activity_current_comment();
$comment is false and is therefore a non-object.
Attachments (1)
Change History (10)
#2
@
10 years ago
- Milestone changed from Awaiting Review to 2.2
Confirmed. I'm not sure why `$activities_template->activity->current_comment is ending up empty here - r-a-y, as I think this is your bit, can you take a look?
#3
@
10 years ago
I think it has something to do with heartbeat as heartbeat changes the display_comments
setting to 'stream'
and I originally tested with the parameter set to default behavior of 'threaded'
.
Will definitely look into it!
Appears to be an issue with hide_sitewide
. Working on a fix.
#4
@
10 years ago
- Component changed from Activity to Template Pack
- Keywords has-patch added
- Version set to 2.0
01.patch
fixes this issue. The problem is we need to explicitly set the show_hidden
parameter when bp-legacy adds the activity comment via AJAX and fetches the new activity ID.
I'd prefer to add this to 2.1 as the change is pretty small and is a pretty annoying bug.
So the next line fails: