Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#5863 closed defect (bug) (fixed)

Activity comment cache not purged when an activity comment is deleted

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0
Component: Activity Keywords: has-patch commit
Cc:

Description

This is a follow-up to ticket:5434#comment:6.

Steps to reproduce:

  1. Enable an object cache
  2. Go to the sitewide activity directory and post an update.
  3. Post an activity reply to that comment. Next, delete the comment.
  4. Refresh the page. The old activity comment should still be shown.

We need to purge the activity comment cache for the parent activity update whenever an activity comment deleted.

01.patch does this and includes a unit test.

Attachments (1)

5863.01.patch (1.5 KB) - added by r-a-y 5 years ago.

Download all attachments as: .zip

Change History (4)

@r-a-y
5 years ago

#1 @DJPaul
5 years ago

Haven't tested this yet or run the test but it looks OK.

#2 @boonebgorges
5 years ago

  • Keywords commit added

Good find. Thanks, r-a-y.

#3 @r-a-y
5 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 8990:

Activity: Purge comment cache when an activity comment is deleted.

Fixes issues with object caching holding deleted activity comments.
Commit also includes a unit test.

Fixes #5863.

Note: See TracTickets for help on using tickets.